Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set LDFLAGS instead of LIBRARY_PATH and add new required keyword to _get_software_root for Fujitsu toolchain #3704

Merged
merged 2 commits into from
May 27, 2021
Merged

set LDFLAGS instead of LIBRARY_PATH and add new required keyword to _get_software_root for Fujitsu toolchain #3704

merged 2 commits into from
May 27, 2021

Conversation

migueldiascosta
Copy link
Member

the required keyword was introduced in #3555

@migueldiascosta migueldiascosta added this to the 4.4.0 milestone May 27, 2021
@migueldiascosta migueldiascosta requested a review from boegel May 27, 2021 01:08
@migueldiascosta migueldiascosta mentioned this pull request May 27, 2021
Closed
34 tasks
@boegel boegel changed the title fujitsu toolchain: set LDFLAGS instead of LIBRARY_PATH and add new required keyword to _get_software_root set LDFLAGS instead of LIBRARY_PATH and add new required keyword to _get_software_root for Fujitsu toolchain May 27, 2021
boegel
boegel approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 9991d5b into easybuilders:develop May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
change
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@migueldiascosta @boegel