-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initial/experimental support for installing extensions in parallel #3667
Conversation
40e394f
to
5f86294
Compare
…add --parallel-extensions-install configuration option to opt-in to it
… steps (like creating of Extension instances)
83a26c8
to
2e5c6ab
Compare
…Extension instances + checking for extensions to skip
Tests in latest commit are failing because To fix that without jumping through lots of code hoops, I've proposed some trivial changes in |
…tually are extensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My testing has been going well and this looks good.
…extensions-install is used
…alling extensions in parallel
…pt-in to support for installing extensions in parallel in various easyblocks
…fter every iteration, and only when not showing progress bars
…False, which indicates that no asynchronous command was started
6d94d39
to
0dd9061
Compare
Now that a test is in place that checks the support for installing extensions in parallel, I think this is ready to merge, in combination with easybuilders/easybuild-easyblocks#2408. I've tested this extensively on a wide range of R easyconfigs, and I've yet to run into a failing installation because of installing extensions in parallel, so at least for R extensions this seems to work really well. Quick summary of requirements to also support parallel installation of other types of extensions:
The changes to the Note that this is marked as an experimental feature and it's opt-in, so it is only used when EasyBuild is configured with both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @boegel! |
WIP because needs enhancements in the test suite + some more testing with R