Sort output of eb --search in natural order (respecting numbers) #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
naturalSortSearch
branch
from
e00431a to
e1f744e
Compare
boegel
requested changes
Mar 16, 2021
There was a problem hiding this comment.
@Flamefire You also need to include the new test subsuite to the general test/suite.py, or those tests will not be run in CI, cfr. Flamefire#5
|
Thanks. I'm too used to pytest which makes writing unit tests so much easier... |
boegel
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the output of
eb --searchmore approachable by sorting versions in natural order. I.e. Foo-10.1 comes *after Foo-9.2Had to create and move a test file to add a test for natural_keys
Code is based on https://stackoverflow.com/a/5967539/1930508 which is based on http://nedbatchelder.com/blog/200712/human_sorting.html