avoid running expensive 'module use' command when using Lmod as modules tool, update $MODULEPATH directly instead #3557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered an issue: The priority.
There are 2 problems:
prepend_module_path
with an optional priority. Hence if we don't pass a priority then this function will not "prepend" the path@boegel
It is a problem if I replace module use by setting MODULEPATH because that would yield a different behavior. I currently check if any priority is in use and fallback to module use instead
We use the priority in
load_fake_module
, but I guess we should not. The problem is: It doesn't tell what is intended. Inprepend_module_path
we could (hard, but possible) check current priorities and choose a higher one. Who knows that the 10000 we currently use isn't in use already or a user used 10001?hence I'd deprecate the priority argument