-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for filtering dependencies by using False as version #3506
add support for filtering dependencies by using False as version #3506
Conversation
Hmm.... wouldn't it be enough to write
to get that effect? And then we could perhaps do,
To only turn it off for POWER, or something, replace "default" with something better... |
I do agree with that, but those changes would be in a different part of the codebase, so I'd prefer not to do it in this PR if possible. The syntax for arch-specific deps exists already - I'm just adding support for specifying version=False (for any dep) so I can say "this arch doesn't want this dep at all". |
Yes, I was just throwing out ideas... |
I do like the |
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going in, thanks @edmondac! |
Useful for architecture-specific deps, e.g.:
So in this example, on POWER don't include a VTK dependency at all