-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check_log_for_errors to detect and handle multiple errors #3118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 10, 2019
Flamefire
force-pushed
the
build_errors
branch
from
December 10, 2019 17:04
7f40924
to
3fb666e
Compare
houndci-bot
reviewed
Dec 10, 2019
Flamefire
force-pushed
the
build_errors
branch
from
December 10, 2019 17:06
3fb666e
to
73c02f0
Compare
boegel
requested changes
Dec 10, 2019
Flamefire
force-pushed
the
build_errors
branch
from
December 11, 2019 13:36
73c02f0
to
b8408b0
Compare
houndci-bot
reviewed
Dec 11, 2019
houndci-bot
reviewed
Dec 11, 2019
Flamefire
force-pushed
the
build_errors
branch
from
December 11, 2019 13:38
b8408b0
to
52c3a6a
Compare
Flamefire
force-pushed
the
build_errors
branch
from
January 6, 2020 09:17
52c3a6a
to
e19374f
Compare
houndci-bot
reviewed
Jan 6, 2020
houndci-bot
reviewed
Jan 6, 2020
boegel
requested changes
Jan 14, 2020
boegel
requested changes
Jan 14, 2020
Rename variables Accept only strings not compiled regExps Split function in 2 for reuse
Flamefire
force-pushed
the
build_errors
branch
from
January 14, 2020 13:13
a9dcbfe
to
8bf84ab
Compare
houndci-bot
reviewed
Jan 14, 2020
Flamefire
force-pushed
the
build_errors
branch
from
January 14, 2020 13:15
8bf84ab
to
c5ca2d9
Compare
boegel
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Flamefire I squeezed in some minor fixes via 0859617, with that in place this is good to go in imho.
I'll go ahead and merge this to be included in the upcoming EasyBuild v4.1.1...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for easybuilders/easybuild-easyblocks#157 I created this PoC.
The specification is (as documented):
In the end you'll get (if appropriate) a logged warning and an exception about the found issues.
I guess this function could even be split: 1 that returns the
(warnings, errors)
tuple and one that also increaseserrors_found_in_log
, logs the warning and raises the exception (which would be the most common usage), but the nameparse_log_for_error
is already taken. Maybe name itparse_log_for_errors
? The "old"parse_log_for_error
can be implemented in terms of that but in can probably be simply deprecated. It is strange, does to much and yet almost nothing. Similar forparse_cmd_output
. So for backwards compatibility I'd rather have EasyBlocks callcheck_log_for_errors
directly and passNone
as theregExp
torun_cmd*