correctly resolve template values used for extensions #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resolved when extensions are installed
|
@akesandgren While working on this I realized there's another problem with templates like More specifically: templates like The reason for this is that the |
akesandgren
approved these changes
May 1, 2019
|
Going in, thanks @boegel! |
ocaisa
reviewed
May 3, 2019
| # construct dictionary with template values; | ||
| # inherited from parent, except for name/version templates which are specific to this extension | ||
| template_values = copy.deepcopy(self.cfg.template_values) | ||
| template_values.update(template_constant_dict(ext_src)) |
There was a problem hiding this comment.
Missing an option here, this should be
template_values.update(template_constant_dict(ext_src, skip_lower=False))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a long-standing issue where using templates in
exts_listeither did not work at all, or where incorrect values were being used (i.e. the ones inherited by the 'parent').fixes #1445, #1597, #1138