-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lmod 8 to test suite #2849
Add Lmod 8 to test suite #2849
Conversation
|
Lmod introduced "extended defaults" in |
@ocaisa I'm not sure disabling a feature in the test setup that's enabled by default and breaks something in EasyBuild is the best way forward here... In what way do the test fail? Are they simply not taking something into account, or are they signaling that something is broken in framework when using Lmod 8.0.7 with the "extended defaults" feature enabled? |
It breaks the modulerc test at https://github.com/easybuilders/easybuild-framework/blob/master/test/framework/module_generator.py#L390 because with extended defaults the central module also evaluated to true. Either we retain the strictness that exists in the other module tools or consider switching this particular test off for Lmod. |
@ocaisa Thart's basically a bug in the tests, for the case where Lmod 8.0.8 or newer is configured with "extended defaults", it's not a bug in EasyBuild itself I guess (although it could lead to weird situations...). There's probably a runtime switch we can enable to tell Lmod to not consider extended defaults when being used by EasyBuild (much like we disable the Lmod spider cache by setting So we should just figure out which magic |
I'm for using the runtime switch, but I suspect that will be a feature request (the configure option to disable extended defaults appeared in |
@boegel When tests pass this should be good to go. |
Thanks @ocaisa! |
No description provided.