--new-pr can't be empty #1846
Merged
--new-pr can't be empty #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -618,6 +618,8 @@ def _easyconfigs_pr_common(paths, start_branch=None, pr_branch=None, target_acco | |||
| print_msg(git_repo.git.diff(cached=True) + '\n', log=_log, prefix=False) | |||
|
|
|||
| diff_stat = git_repo.git.diff(cached=True, stat=True) | |||
| if not diff_stat: | |||
| raise EasyBuildError("No changed files found. Refused to make empty pull request.") | |||
There was a problem hiding this comment.
clarify error message, somehow mention that you were comparing with current develop branch (but keep it short, people don't actually read long errors ;-))
| # get file from develop branch | ||
| full_url = URL_SEPARATOR.join([GITHUB_RAW, GITHUB_EB_MAIN, GITHUB_EASYCONFIGS_REPO, | ||
| 'develop/easybuild/easyconfigs/z/zlib/zlib-1.2.8.eb']) | ||
| ec = download_file('zlib-1.2.8.eb', full_url, path=os.path.join(self.test_prefix, 'zlib-1.2.8.eb'), forced=True) |
There was a problem hiding this comment.
derive 'zlib-1.2.8.eb' from full_url?
ec_fn = os.path.basename(full_url)
ec = download_file(ec_fn, full_url, path=os.path.join(self.test_prefix, ec_fn), forced=True)the forced is probably not needed (self.test_prefix will be an empty dir)
|
lgtm, thanks @Caylo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1687