Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break after deleting cache entry to avoid attempt to delete cache entry again #1776

Merged
merged 2 commits into from
May 22, 2016

Conversation

boegel
Copy link
Member

@boegel boegel commented May 21, 2016

This fixes #1775.

Without the break, the enhanced test fails with:

======================================================================
ERROR: test_module_caches (__main__.ModulesTest)
Test module caches and invalidate_module_caches_for function.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/framework/modules.py", line 583, in test_module_caches
    invalidate_module_caches_for(test_mods_path)
  File "/Users/kehoste/work/easybuild-framework/easybuild/tools/modules.py", line 1150, in invalidate_module_caches_for
    key, subcmd, path, cache[key])
KeyError: ('MODULEPATH=/var/folders/8s/_frgh9sj6m744mxt5w5lyztr0000gn/T/eb-Jvxp9Y/eb-fN6MJC/modules_symlink:/var/folders/8s/_frgh9sj6m744mxt5w5lyztr0000gn/T/eb-Jvxp9Y/eb-fN6MJC/nosuchfileordirectory:/Users/kehoste/work/easybuild-framework/test/framework/modules', 'modulecmd', '')

----------------------------------------------------------------------

@boegel boegel added this to the v2.9.0 milestone May 21, 2016
@boegel boegel modified the milestones: v2.9.0, v2.8.1 May 21, 2016
@boegel
Copy link
Member Author

boegel commented May 22, 2016

fix confirmed by @brettbode in #1775, going in

Thanks for reporting the bug in detail @brettbode!

@boegel boegel merged commit 2e51d6f into easybuilders:develop May 22, 2016
@boegel boegel deleted the module_cache_bug branch May 22, 2016 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant