Generic compilation support #1471
Conversation
| systemtools.POWER: 'mcpu=native', # no support for march=native on POWER | ||
| } | ||
| optarch = build_option('optarch') | ||
| if optarch == 'GENERIC': |
There was a problem hiding this comment.
this should be a constant named GENERIC, that you import from easybuild.tools.toolchain.toolchain
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2324/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2335/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2336/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2337/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
…ptarch' toolchain option)
fix --list-toolchains, always include generic flags (regardless of 'optarch' toolchain option)
|
Jenkins: test this please |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2355/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@pescobar: this still needs:
|
|
Is it worth supporting something in between generic and native? |
|
@rjeschmi I tried to build a software stack "in between" to use it as my generic software stack and I got problems. My specific case was that I was compiling my "generic" software stack in the oldest cpu I had around which was a nehalem. I was building in the nehalem cpu with the default gcc option in easybuild of "-march=native" and I supposed that this would work in any other cpu but I found problems when trying to use this software stack in AMD cpus (magny-cours I think) and also when using it in xenserver virtual machines. That's why I would suggest to build totally generic. I would focus this feature in portability and not in performance |
|
I did some tests and seems to be working for GCC. See this three build logs: This one is a normal build without using --optarch This one is with --optarch=GENERIC and toolchainopts = {'optarch': True} This one is with --optarch=GENERIC and toolchainopts = {'optarch': False} If you grep for "march" in those build logs all them seem fine for me. Opinions @boegel ? |
|
@pescobar: seems to be working indeed, so go ahead with the docs update |
| optarch = build_option('optarch', default=None) | ||
| if optarch == OPTARCH_GENERIC: | ||
| # do generic build if --optarch=GENERIC | ||
| COMPILER_OPTIMAL_ARCHITECTURE_OPTION = { |
There was a problem hiding this comment.
this should be self.COMPILER_OPTIMAL_ARCHITECTURE_OPTION = {
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2407/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@pescobar: unit test + cleanup in pescobar#16 |
add unit test for --optarch=GENERIC + clean up way in which --optarch=GENERIC is handled
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2411/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2412/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Going in, thanks @pescobar! docs update at easybuilders/easybuild#172 will be included soon too |
No description provided.