-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 'whatis' easyconfig parameter #1271
Conversation
"module whatis" output generation
Automatic reply from Jenkins: Can I test this? |
Jenkins: ok to test |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
sync with develop
While looking at this again, I noticed that the lua version includes the name and version twice: once as a prefix to the output and once as the output itself. Does it make sense to rectify this? Maybe we should also get @pforai on board? |
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Here is an example to clarify what I meant by my last comment:
The GCC/4.9.2 module is in Lua format, GCC/4.8.2 is Tcl. |
@geimer: let's follow this up in August, tagging this for EB v2.3 |
@boegel: Do you think we can finalize this in time for EB v2.4.0? |
@geimer: doesn't look like a lot of work, but I don't want to rush it in either, especially since it's likely we'll be doing some work on the module generator part at the hackathon in Austin, cfr. #1358 Also, I would really like to try and get #1306 ready to merge (needs code cleanup & unit tests), and to get #1388 merged as well. I'm not sure how I'll ever pull that off, so I'm not keen on adding other stuff on top of it. ;-) How about we revisit this together with what needs to be done for #1358? |
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2241/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
@geimer: moved to milestone 2.5.0 (which should be there by the end of 2015), let's try and work on this during the hackathon in Austin |
…rate whatis statement in the modulefile
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2332/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2334/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
The latest version of this PR removes the inconsistency between Lua and Tcl modules mentioned above. This also addresses the desire of TACC to be able to specify, for example, the version explicitly (see #1358) , which may conflict with the automatically generated string. |
use None as default value for whatis + minor style fixes
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2382/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Going in (finally), thanks for your efforts on this @geimer! |
Add support for 'whatis' easyconfig parameter
Currently, the
module whatis
output includes the full package description. This PR adds support for a new (optional) easyconfig parameterwhatis
. If given, the value will be used when generating the modulefile; otherwise it will fall back to using the value ofdescription
for backwards compatibility.