Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable change in module cray-libsci of CPE 23.12 #4536

Closed
lucamar opened this issue May 17, 2024 · 2 comments · Fixed by #4551
Closed

Environment variable change in module cray-libsci of CPE 23.12 #4536

lucamar opened this issue May 17, 2024 · 2 comments · Fixed by #4551
Labels
cray Issues and PRs related to integration with Cray PE problem report
Milestone

Comments

@lucamar
Copy link

lucamar commented May 17, 2024

Hi, I report a bug affecting EasyBuild on Cray systems (file libsci.py) with the Cray Programming Environment (CPE) 23.12. The bug should be fixed in CPE 24.03 according to HPE/Cray staff, therefore the impact is limited:

  • The environment variable name referenced in line 68 changed from CRAY_LIBSCI_PREFIX_DIR to CRAY_PE_LIBSCI_PREFIX_DIR
  • I have manually fixed line 69 using the workaround below:
    root = os.getenv('CRAY_LIBSCI_PREFIX_DIR', None) or os.getenv('CRAY_PE_LIBSCI_PREFIX_DIR', None)

The environment variable name should be fixed back to the original one in CPE 24.03 (I did not have the chance to test it yet, though). Since CPE variable names change sometimes, it might be useful to give the option to read the prefix of the external module cray-libsci from a metadata file instead of having it hard coded.

@boegel boegel added problem report cray Issues and PRs related to integration with Cray PE labels May 22, 2024
@boegel boegel added this to the 4.x milestone May 22, 2024
@boegel
Copy link
Member

boegel commented May 22, 2024

@lucamar Do you think it's worth also considering $CRAY_PE_LIBSCI_PREFIX_DIR as a fallback in libsci.py to dance around this? That's a pretty easy change...

@lucamar
Copy link
Author

lucamar commented May 23, 2024

Thanks @boegel: yes, that's likely the quickest workaround, that I've also implemented manually. Hopefully this bug will only affect CPE 23.12, as reported by HPE staff

boegel added a commit to boegel/easybuild-framework that referenced this issue Jun 6, 2024
boegel added a commit to boegel/easybuild-framework that referenced this issue Jun 6, 2024
boegel added a commit to boegel/easybuild-framework that referenced this issue Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cray Issues and PRs related to integration with Cray PE problem report
Projects
None yet
2 participants