Correctly restore sys.path in tests

easybuilders · Jul 28, 2021 · 541c41f · 541c41f
1 parent 77c5e5b
commit 541c41f
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 8 deletions.
diff --git a/test/framework/config.py b/test/framework/config.py
@@ -494,7 +494,9 @@ def test_flex_robot_paths(self):
 
         # prepend path to test easyconfigs into Python search path, so it gets picked up as --robot-paths default
         orig_sys_path = sys.path[:]
-        sys.path = [tmpdir] + [p for p in sys.path if not os.path.exists(os.path.join(p, 'easybuild', 'easyconfigs'))]
+        sys.path[:] = [tmpdir] + [
+            p for p in sys.path if not os.path.exists(os.path.join(p, 'easybuild', 'easyconfigs'))
+        ]
 
         # default: only pick up installed easyconfigs via sys.path
         eb_go = eboptions.parse_options(args=[])

diff --git a/test/framework/easyconfig.py b/test/framework/easyconfig.py
@@ -3527,7 +3527,7 @@ def test_get_paths_for(self):
         self.assertEqual(res[-1], os.path.join(symlinked_prefix, 'easybuild', 'easyconfigs'))
 
         # wipe sys.path. then only path found via $EB_SCRIPT_PATH is found
-        sys.path = []
+        sys.path[:] = []
         res = get_paths_for(subdir='easyconfigs', robot_path=None)
         self.assertEqual(len(res), 1)
         self.assertEqual(res[0], os.path.join(symlinked_prefix, 'easybuild', 'easyconfigs'))

diff --git a/test/framework/options.py b/test/framework/options.py
@@ -3213,7 +3213,7 @@ def test_xxx_include_easyblocks(self):
 
         # 'undo' import of foo easyblock
         del sys.modules['easybuild.easyblocks.foo']
-        sys.path = orig_local_sys_path
+        sys.path[:] = orig_local_sys_path
         import easybuild.easyblocks
         reload(easybuild.easyblocks)
         import easybuild.easyblocks.generic
@@ -3333,7 +3333,7 @@ def test_xxx_include_generic_easyblocks(self):
         # 'undo' import of foobar easyblock
         del sys.modules['easybuild.easyblocks.generic.foobar']
         os.remove(os.path.join(self.test_prefix, 'generic', 'foobar.py'))
-        sys.path = orig_local_sys_path
+        sys.path[:] = orig_local_sys_path
         import easybuild.easyblocks
         reload(easybuild.easyblocks)
         import easybuild.easyblocks.generic
@@ -3432,7 +3432,7 @@ def test_github_xxx_include_easyblocks_from_pr(self):
         del sys.modules['easybuild.easyblocks.foo']
         del sys.modules['easybuild.easyblocks.generic.cmakemake']
         os.remove(os.path.join(self.test_prefix, 'foo.py'))
-        sys.path = orig_local_sys_path
+        sys.path[:] = orig_local_sys_path
 
         # include test cmakemake easyblock
         cmm_txt = '\n'.join([
@@ -3491,7 +3491,7 @@ def test_github_xxx_include_easyblocks_from_pr(self):
         del sys.modules['easybuild.easyblocks.foo']
         del sys.modules['easybuild.easyblocks.generic.cmakemake']
         os.remove(os.path.join(self.test_prefix, 'cmakemake.py'))
-        sys.path = orig_local_sys_path
+        sys.path[:] = orig_local_sys_path
         import easybuild.easyblocks
         reload(easybuild.easyblocks)
         import easybuild.easyblocks.generic

diff --git a/test/framework/toy_build.py b/test/framework/toy_build.py
@@ -410,7 +410,7 @@ def test_toy_build_with_blocks(self):
 
         # cleanup
         shutil.rmtree(tmpdir)
-        sys.path = orig_sys_path
+        sys.path[:] = orig_sys_path
 
     def test_toy_build_formatv2_sections(self):
         """Perform a toy build (format v2, using sections)."""

diff --git a/test/framework/utilities.py b/test/framework/utilities.py
@@ -231,7 +231,7 @@ def tearDown(self):
         self.allow_deprecated_behaviour()
 
         # restore original Python search path
-        sys.path = self.orig_sys_path
+        sys.path[:] = self.orig_sys_path
         import easybuild.easyblocks
         reload(easybuild.easyblocks)
         import easybuild.easyblocks.generic