{vis} [intel/2016b] Mesa/12.0.1 (REVIEW) #3460
Conversation
|
Python is still a major issue here: currently we build it with Tk which needs X11... This needs to change. |
| @@ -20,6 +20,7 @@ dependencies = [ | |||
| ('zlib', '1.2.8'), | |||
| ] | |||
|
|
|||
| # To be clear: this will still require the X11 to be present. | |||
There was a problem hiding this comment.
if you add this, include a pointer to #2261
There was a problem hiding this comment.
also, this is totally unrelated to this PR (this particular Tk easyconfig isn't used here, it's even a different toolchain)
let's not start adding comments left and right for stuff we already have open issues for
Build the Tk module for Python requires a full X11 stack. We want to avoid that.
| @@ -18,7 +18,8 @@ dependencies = [ | |||
| ('libreadline', '6.3'), | |||
| ('ncurses', '6.0'), | |||
| ('SQLite', '3.13.0'), | |||
| ('Tk', '8.6.5'), | |||
| # We don't build Tkinter as it requires an X11 stack | |||
| # ('Tk', '8.6.5'), | |||
There was a problem hiding this comment.
@wpoely86 this should be done in a separate PR for sure, together with providing a separate easyconfig for Tkinter itself
also, we shouldn't make this change before EasyBuild v3.0.0
There was a problem hiding this comment.
Then all the work is fully blocked. No Mesa, no openfoam, no paraview. This is a major blocker and it needs to go
There was a problem hiding this comment.
@wpoely86 only if you don't have X11 in the OS, but we do...
There was a problem hiding this comment.
then you need to put in os deps. This PR doesn't work without this line.
There was a problem hiding this comment.
it never works, or only if you don't have X11 on the OS?
There was a problem hiding this comment.
you need a X11 stack for Tk.
There was a problem hiding this comment.
I know you do, but I still don't see how that's a blocker for this PR.
Currently, our Tk easyconfigs require to have X11 provided by the OS, whatever the versionsuffix or configure options say. We should definitely fix that, but this shouldn't block any other PRs?
* develop: add easyconfig gperftools-2.5-intel-2016b.eb add easyconfig gperftools-2.5-intel-2016b.eb, add easyconfig libunwind-1.1-intel-2016b.eb Circos 0.69-2 using ictce 5.5.0 toolchain clean up libxml2 easyconfigs according to updated libxml2 easyblock Add comment in patch about it's purpose Add CMake/3.6.1 for intel/2016b
wpoely86
changed the title
|
Test report by @wpoely86 |
|
Test report by @wpoely86 |
| @@ -18,6 +18,7 @@ dependencies = [ | |||
| ('libreadline', '6.3'), | |||
| ('ncurses', '6.0'), | |||
| ('SQLite', '3.13.0'), | |||
| # Be ware that this requires a full X11 stack | |||
There was a problem hiding this comment.
pfft, is this worth adding here? we already have open issues for this, etc.
There was a problem hiding this comment.
yes, people will look at the easyconfigs but not that the issues. And this is major.
|
lgtm |
|
Test report by @wpoely86 |
|
The last one shows what happens on systems without X. |
|
Test report by @wpoely86 |
|
Going in, thanks @wpoely86! |
Needs
#3440and#3407