-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add easyconfigs for SuperLU library #2665
Conversation
Automatic reply from Jenkins: Can I test this? |
Jenkins: ok to test |
checksums = ['260a3cd90b2100122abff38587a8290a'] | ||
|
||
# Set to ON to generate shared library | ||
configopts = "-DBUILD_SHARED_LIBS=OFF" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not always build the shared libs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, they build the static library, so I just left it like this. Also, it's exclusive, if you set BUILD_SHARED_LIBS=ON
, it will build the shared library, and not the static one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, ok...
EB has a way of dealing with that BTW:
configopts = [
"-DBUILD_SHARED_LIBS=OFF",
"-DBUILD_SHARED_LIBS=ON",
]
but you'd to adjust more below (the +=
lines for configopts
, and the installopts
which is now specific to static libs
but fine, OK to leave as is I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do? This make two builds and install them at the same place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will make EB go through the configure/build/install cycle two times, but keeping the same install target.
See the FFTW easyconfigs
Test report by @boegel |
Test report by @boegel |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6894/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6897/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
thanks about this!
and to be sure:
so, thank you again |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6915/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6929/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6939/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6947/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6948/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7001/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
@boegel I have not re-tested, but it should be ready to go |
break up long lines in SuperLu easyconfigs
Test report by @boegel |
Test report by @boegel |
Good to go, thanks @besserox! |
thanks @besserox : this was sitting in some wishlists for a couple of years |
I have created these easyconfigs for the SuperLU library, which is not supported yet by EasyBuild.
@boegel Should I create an easyblock for SuperLU to hide all this complexity?
edit: depends on
easybuilders/easybuild-easyblocks#860