Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add easyconfigs for SuperLU library #2665

Merged
merged 14 commits into from
May 13, 2016
Merged

Conversation

besserox
Copy link
Contributor

@besserox besserox commented Mar 8, 2016

I have created these easyconfigs for the SuperLU library, which is not supported yet by EasyBuild.

@boegel Should I create an easyblock for SuperLU to hide all this complexity?

edit: depends on easybuilders/easybuild-easyblocks#860

@hpcugentbot
Copy link

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Member

boegel commented Mar 8, 2016

Jenkins: ok to test

@boegel boegel added this to the v2.7.0 milestone Mar 8, 2016
checksums = ['260a3cd90b2100122abff38587a8290a']

# Set to ON to generate shared library
configopts = "-DBUILD_SHARED_LIBS=OFF"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not always build the shared libs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, they build the static library, so I just left it like this. Also, it's exclusive, if you set BUILD_SHARED_LIBS=ON, it will build the shared library, and not the static one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, ok...

EB has a way of dealing with that BTW:

configopts = [
    "-DBUILD_SHARED_LIBS=OFF",
    "-DBUILD_SHARED_LIBS=ON",
]

but you'd to adjust more below (the += lines for configopts, and the installopts which is now specific to static libs

but fine, OK to leave as is I guess

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? This make two builds and install them at the same place?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will make EB go through the configure/build/install cycle two times, but keeping the same install target.

See the FFTW easyconfigs

@boegel
Copy link
Member

boegel commented Mar 8, 2016

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2668.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/13e1a2cb3b842d9cc56e for a full test report.

@boegel
Copy link
Member

boegel commented Mar 8, 2016

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2090.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/c3d22d29ceee0df66f47 for a full test report.

@hpcugentbot
Copy link

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6894/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6897/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@besserox besserox changed the title Add easyconfigs for SuperLU library [WIP] Add easyconfigs for SuperLU library Mar 8, 2016
@hpcugentbot
Copy link

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6915/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6929/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@besserox besserox changed the title [WIP] Add easyconfigs for SuperLU library Add easyconfigs for SuperLU library Mar 9, 2016
@hpcugentbot
Copy link

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6939/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6947/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6948/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7001/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@boegel boegel modified the milestones: v2.7.0, v2.8.0 Mar 14, 2016
@boegel boegel modified the milestones: v2.8.0, v2.9.0 May 10, 2016
@besserox
Copy link
Contributor Author

@boegel I have not re-tested, but it should be ready to go

@boegel boegel modified the milestones: v2.8.0, v2.9.0 May 12, 2016
break up long lines in SuperLu easyconfigs
@boegel
Copy link
Member

boegel commented May 13, 2016

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2159.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/44c888f5c988f5f36c2a072fdf616bcf for a full test report.

@boegel
Copy link
Member

boegel commented May 13, 2016

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2402.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/ef216a170796d2f17b8ad560e75bac8b for a full test report.

@boegel
Copy link
Member

boegel commented May 13, 2016

Good to go, thanks @besserox!

@boegel boegel merged commit e80fcb9 into easybuilders:develop May 13, 2016
@fgeorgatos
Copy link
Contributor

thanks @besserox : this was sitting in some wishlists for a couple of years

@besserox besserox deleted the superlu branch May 24, 2016 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants