Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{ai,bio}[foss/2024a] AlphaFold3 v3.0.0.20250220, jax-triton v0.2.0, jaxtyping v0.2.38, dm-tree v0.1.8 w/ CUDA 12.6.0 DRAFT! #22067

Draft
wants to merge 25 commits into
base: develop
Choose a base branch
from

Conversation

ThomasHoffmann77
Copy link
Contributor

@ThomasHoffmann77 ThomasHoffmann77 commented Dec 19, 2024

(created using eb --new-pr)

TODO:

  • "alphafold3 3.0.0 requires rdkit, which is not installed." although RDKit is dependency -> add minimal rdkit-2024.03.5.dist-info
  • disable fetchcontent
  • dssp
  • pybind11_abseil
  • RDKit: check whether 2024_09_4 (latest) would also work
  • Check, whether $TRITON_HOME is used at all. Otherwise remove from module(xxx)footer.
  • teststep: run_alphafold_tests.py

…riton-0.1.1-foss-2024a-CUDA-12.6.0.eb and patches: jax-triton-0.1.1_ignore_missing_torch.patch
@ThomasHoffmann77 ThomasHoffmann77 changed the title {ai,bio}[foss/2024a] AlphaFold3 v3.0.0, jax-triton v0.1.1 w/ CUDA 12.6.0 {ai,bio}[foss/2024a] AlphaFold3 v3.0.0, jax-triton v0.1.1 w/ CUDA 12.6.0 DRAFT! Dec 19, 2024
@ThomasHoffmann77 ThomasHoffmann77 marked this pull request as draft December 19, 2024 15:12
@github-actions github-actions bot added the new label Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

Updated software dm-tree-0.1.9-gfbf-2024a.eb

Diff against dm-tree-0.1.8-GCCcore-12.3.0.eb

easybuild/easyconfigs/d/dm-tree/dm-tree-0.1.8-GCCcore-12.3.0.eb

diff --git a/easybuild/easyconfigs/d/dm-tree/dm-tree-0.1.8-GCCcore-12.3.0.eb b/easybuild/easyconfigs/d/dm-tree/dm-tree-0.1.9-gfbf-2024a.eb
index bf55444d00..3be4da4929 100644
--- a/easybuild/easyconfigs/d/dm-tree/dm-tree-0.1.8-GCCcore-12.3.0.eb
+++ b/easybuild/easyconfigs/d/dm-tree/dm-tree-0.1.9-gfbf-2024a.eb
@@ -1,23 +1,32 @@
 easyblock = 'PythonPackage'
 
 name = 'dm-tree'
-version = '0.1.8'
+version = '0.1.9'
 
 homepage = 'https://github.com/deepmind/tree'
 description = """dm-tree provides tree, a library for working with nested data structures. In a way,
 tree generalizes the builtin map function which only supports flat sequences, and
 allows to apply a function to each "leaf" preserving the overall structure."""
 
-toolchain = {'name': 'GCCcore', 'version': '12.3.0'}
+toolchain = {'name': 'gfbf', 'version': '2024a'}
 
-sources = [SOURCELOWER_TAR_GZ]
-checksums = ['0fcaabbb14e7980377439e7140bd05552739ca5e515ecb3119f234acee4b9430']
+sources = ['dm_tree-%(version)s.tar.gz']
+patches = ['dm-tree-0.1.9_pybind11.patch']
+checksums = [
+    {'dm_tree-0.1.9.tar.gz': 'a4c7db3d3935a5a2d5e4b383fc26c6b0cd6f78c6d4605d3e7b518800ecd5342b'},
+    {'dm-tree-0.1.9_pybind11.patch': '39ae1e40e6a027a6c6e085b20d33fe8de0e8103963c2ae0da665597ed9c6b41b'},
+]
 
 builddependencies = [
-    ('binutils', '2.40'),
-    ('CMake', '3.26.3'),
+    ('pybind11', '2.12.0'),
+]
+dependencies = [
+    ('Python', '3.12.3'),
+    ('absl-py', '2.1.0'),
+    ('Abseil', '20240722.0'),
+    ('SciPy-bundle', '2024.05'),
+    ('wrapt', '1.16.0'),
 ]
-dependencies = [('Python', '3.11.3')]
 
 download_dep_fail = True
 
Diff against dm-tree-0.1.8-GCCcore-11.3.0.eb

easybuild/easyconfigs/d/dm-tree/dm-tree-0.1.8-GCCcore-11.3.0.eb

diff --git a/easybuild/easyconfigs/d/dm-tree/dm-tree-0.1.8-GCCcore-11.3.0.eb b/easybuild/easyconfigs/d/dm-tree/dm-tree-0.1.9-gfbf-2024a.eb
old mode 100755
new mode 100644
index 94b5023db0..3be4da4929
--- a/easybuild/easyconfigs/d/dm-tree/dm-tree-0.1.8-GCCcore-11.3.0.eb
+++ b/easybuild/easyconfigs/d/dm-tree/dm-tree-0.1.9-gfbf-2024a.eb
@@ -1,23 +1,32 @@
 easyblock = 'PythonPackage'
 
 name = 'dm-tree'
-version = '0.1.8'
+version = '0.1.9'
 
 homepage = 'https://github.com/deepmind/tree'
 description = """dm-tree provides tree, a library for working with nested data structures. In a way,
 tree generalizes the builtin map function which only supports flat sequences, and
 allows to apply a function to each "leaf" preserving the overall structure."""
 
-toolchain = {'name': 'GCCcore', 'version': '11.3.0'}
+toolchain = {'name': 'gfbf', 'version': '2024a'}
 
-sources = [SOURCELOWER_TAR_GZ]
-checksums = ['0fcaabbb14e7980377439e7140bd05552739ca5e515ecb3119f234acee4b9430']
+sources = ['dm_tree-%(version)s.tar.gz']
+patches = ['dm-tree-0.1.9_pybind11.patch']
+checksums = [
+    {'dm_tree-0.1.9.tar.gz': 'a4c7db3d3935a5a2d5e4b383fc26c6b0cd6f78c6d4605d3e7b518800ecd5342b'},
+    {'dm-tree-0.1.9_pybind11.patch': '39ae1e40e6a027a6c6e085b20d33fe8de0e8103963c2ae0da665597ed9c6b41b'},
+]
 
 builddependencies = [
-    ('binutils', '2.38'),
-    ('CMake', '3.23.1'),
+    ('pybind11', '2.12.0'),
+]
+dependencies = [
+    ('Python', '3.12.3'),
+    ('absl-py', '2.1.0'),
+    ('Abseil', '20240722.0'),
+    ('SciPy-bundle', '2024.05'),
+    ('wrapt', '1.16.0'),
 ]
-dependencies = [('Python', '3.10.4')]
 
 download_dep_fail = True
 
Diff against dm-tree-0.1.6-GCCcore-10.3.0.eb

easybuild/easyconfigs/d/dm-tree/dm-tree-0.1.6-GCCcore-10.3.0.eb

diff --git a/easybuild/easyconfigs/d/dm-tree/dm-tree-0.1.6-GCCcore-10.3.0.eb b/easybuild/easyconfigs/d/dm-tree/dm-tree-0.1.9-gfbf-2024a.eb
index de8beea149..3be4da4929 100644
--- a/easybuild/easyconfigs/d/dm-tree/dm-tree-0.1.6-GCCcore-10.3.0.eb
+++ b/easybuild/easyconfigs/d/dm-tree/dm-tree-0.1.9-gfbf-2024a.eb
@@ -1,23 +1,32 @@
 easyblock = 'PythonPackage'
 
 name = 'dm-tree'
-version = '0.1.6'
+version = '0.1.9'
 
 homepage = 'https://github.com/deepmind/tree'
 description = """dm-tree provides tree, a library for working with nested data structures. In a way,
 tree generalizes the builtin map function which only supports flat sequences, and
 allows to apply a function to each "leaf" preserving the overall structure."""
 
-toolchain = {'name': 'GCCcore', 'version': '10.3.0'}
+toolchain = {'name': 'gfbf', 'version': '2024a'}
 
-sources = [SOURCELOWER_TAR_GZ]
-checksums = ['6776404b23b4522c01012ffb314632aba092c9541577004ab153321e87da439a']
+sources = ['dm_tree-%(version)s.tar.gz']
+patches = ['dm-tree-0.1.9_pybind11.patch']
+checksums = [
+    {'dm_tree-0.1.9.tar.gz': 'a4c7db3d3935a5a2d5e4b383fc26c6b0cd6f78c6d4605d3e7b518800ecd5342b'},
+    {'dm-tree-0.1.9_pybind11.patch': '39ae1e40e6a027a6c6e085b20d33fe8de0e8103963c2ae0da665597ed9c6b41b'},
+]
 
 builddependencies = [
-    ('binutils', '2.36.1'),
-    ('Bazel', '3.7.2'),
+    ('pybind11', '2.12.0'),
+]
+dependencies = [
+    ('Python', '3.12.3'),
+    ('absl-py', '2.1.0'),
+    ('Abseil', '20240722.0'),
+    ('SciPy-bundle', '2024.05'),
+    ('wrapt', '1.16.0'),
 ]
-dependencies = [('Python', '3.9.5')]
 
 download_dep_fail = True
 

@github-actions github-actions bot removed the update label Dec 19, 2024
@ThomasHoffmann77 ThomasHoffmann77 changed the title {ai,bio}[foss/2024a] AlphaFold3 v3.0.0, jax-triton v0.1.1 w/ CUDA 12.6.0 DRAFT! {ai,bio}[foss/2024a] AlphaFold3 v3.0.0, jax-triton v0.2.0 w/ CUDA 12.6.0 DRAFT! Dec 19, 2024
@ThomasHoffmann77 ThomasHoffmann77 changed the title {ai,bio}[foss/2024a] AlphaFold3 v3.0.0, jax-triton v0.2.0 w/ CUDA 12.6.0 DRAFT! {ai,bio}[foss/2024a] AlphaFold3 v3.0.0, jax-triton v0.2.0, jaxtyping v0.2.36 w/ CUDA 12.6.0 DRAFT! Dec 19, 2024
@ThomasHoffmann77 ThomasHoffmann77 changed the title {ai,bio}[foss/2024a] AlphaFold3 v3.0.0, jax-triton v0.2.0, jaxtyping v0.2.36 w/ CUDA 12.6.0 DRAFT! {ai,bio}[foss/2024a] AlphaFold3 v3.0.0, jax-triton v0.2.0, jaxtyping v0.2.36, dm-tree v0.1.8 w/ CUDA 12.6.0 DRAFT! Dec 20, 2024
@ThomasHoffmann77
Copy link
Contributor Author

dm-tree pybind11 patch taken from debian: https://udd.debian.org/patches.cgi?src=dm-tree&version=0.1.8-3

@ThomasHoffmann77 ThomasHoffmann77 changed the title {ai,bio}[foss/2024a] AlphaFold3 v3.0.0, jax-triton v0.2.0, jaxtyping v0.2.36, dm-tree v0.1.8 w/ CUDA 12.6.0 DRAFT! {ai,bio}[foss/2024a] AlphaFold3 v3.0.0, jax-triton v0.2.0, jaxtyping v0.2.36, dm-tree v0.1.8, RDKit v2024.03.5 w/ CUDA 12.6.0 DRAFT! Jan 16, 2025
@ThomasHoffmann77 ThomasHoffmann77 changed the title {ai,bio}[foss/2024a] AlphaFold3 v3.0.0, jax-triton v0.2.0, jaxtyping v0.2.36, dm-tree v0.1.8, RDKit v2024.03.5 w/ CUDA 12.6.0 DRAFT! {ai,bio}[foss/2024a] AlphaFold3 v3.0.0.20250109, jax-triton v0.2.0, jaxtyping v0.2.36, dm-tree v0.1.8, RDKit v2024.03.5 w/ CUDA 12.6.0 DRAFT! Jan 16, 2025
@VRehnberg
Copy link
Contributor

Are you still working on this @ThomasHoffmann77?

@ThomasHoffmann77
Copy link
Contributor Author

ThomasHoffmann77 commented Feb 3, 2025

Are you still working on this @ThomasHoffmann77?

yes, I am still working on it. First draft is functional. Jax requires some more work to allow offline builds. For RDKit I get one failing test for all our archs except for znver2.
Any of you suggestions would be appreciated @VRehnberg

@ThomasHoffmann77 ThomasHoffmann77 changed the title {ai,bio}[foss/2024a] AlphaFold3 v3.0.0.20250109, jax-triton v0.2.0, jaxtyping v0.2.36, dm-tree v0.1.8, RDKit v2024.03.5 w/ CUDA 12.6.0 DRAFT! {ai,bio}[foss/2024a] AlphaFold3 v3.0.0.20250109, jax-triton v0.2.0, jaxtyping v0.2.36, dm-tree v0.1.8 w/ CUDA 12.6.0 DRAFT! Feb 12, 2025
…oss-2024a-CUDA-12.6.0.eb

Co-authored-by: Viktor Rehnberg <35767167+VRehnberg@users.noreply.github.com>
@VRehnberg
Copy link
Contributor

VRehnberg commented Feb 26, 2025

I'm currently waiting to access the model weights so that I can try this out. But, in the meantime, some initial notes:

  • this built fine (I built with --ignore-test-failures to get past failures in RDKit, but it doesn't seem to have been needed for AlphaFold3 at least (haven't checked the rest))
  • a version bump of at least AlphaFold to get the latest bugfixes would be good

@ThomasHoffmann77
Copy link
Contributor Author

I'm currently waiting to access the model weights so that I can try this out. But, in the meantime, some initial notes:

  • this built fine (I built with --ignore-test-failures to get past failures in RDKit, but it doesn't seem to have been needed for AlphaFold3 at least (haven't checked the rest))
  • a version bump of at least AlphaFold to get the latest bugfixes would be good

Thanks for testing. I'll have a look on it in the afternoon

@ThomasHoffmann77 ThomasHoffmann77 changed the title {ai,bio}[foss/2024a] AlphaFold3 v3.0.0.20250109, jax-triton v0.2.0, jaxtyping v0.2.36, dm-tree v0.1.8 w/ CUDA 12.6.0 DRAFT! {ai,bio}[foss/2024a] AlphaFold3 v3.0.0.20250220, jax-triton v0.2.0, jaxtyping v0.2.36, dm-tree v0.1.8 w/ CUDA 12.6.0 DRAFT! Feb 27, 2025
@ThomasHoffmann77 ThomasHoffmann77 changed the title {ai,bio}[foss/2024a] AlphaFold3 v3.0.0.20250220, jax-triton v0.2.0, jaxtyping v0.2.36, dm-tree v0.1.8 w/ CUDA 12.6.0 DRAFT! {ai,bio}[foss/2024a] AlphaFold3 v3.0.0.20250220, jax-triton v0.2.0, jaxtyping v0.2.38, dm-tree v0.1.8 w/ CUDA 12.6.0 DRAFT! Feb 27, 2025
@ThomasHoffmann77
Copy link
Contributor Author

I'm currently waiting to access the model weights so that I can try this out. But, in the meantime, some initial notes:

  • this built fine (I built with --ignore-test-failures to get past failures in RDKit, but it doesn't seem to have been needed for AlphaFold3 at least (haven't checked the rest))
  • a version bump of at least AlphaFold to get the latest bugfixes would be good

Thanks for testing. I'll have a look on it in the afternoon

@VRehnberg I bumped to commit 792e61e and updated some of the dependencies (probably not required).
RDkit is used in common/folding_input.py, constants/periodic_table.py, data/tools/rdkit_utils.py, model/atom_layout/atom_layout.py, model/features.py, and structure/chemical_components.py

@VRehnberg
Copy link
Contributor

@VRehnberg I bumped to commit 792e61e and updated some of the dependencies (probably not required). RDkit is used in common/folding_input.py, constants/periodic_table.py, data/tools/rdkit_utils.py, model/atom_layout/atom_layout.py, model/features.py, and structure/chemical_components.py

@ThomasHoffmann77 I meant latest release v3.0.1. Any reason you're using commits?

@ThomasHoffmann77
Copy link
Contributor Author

@VRehnberg I bumped to commit 792e61e and updated some of the dependencies (probably not required). RDkit is used in common/folding_input.py, constants/periodic_table.py, data/tools/rdkit_utils.py, model/atom_layout/atom_layout.py, model/features.py, and structure/chemical_components.py

@ThomasHoffmann77 I meant latest release v3.0.1. Any reason you're using commits?

I just was not aware that there has been a release tag. I'll change it to 3.0.1. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants