Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LLVM easyconfigs as required by revamped custom easyblock for LLVM + add lit and git as build dependencies #20902

Merged
merged 48 commits into from
Mar 8, 2025

Conversation

Crivella
Copy link
Contributor

@Crivella Crivella commented Jun 25, 2024

EC files to compile LLVMcore (clang + flang-new + optional projects)

More notes on the EB PR

@boegel
Copy link
Member

boegel commented Jul 31, 2024

@boegelbot please test @ generoso
CORE_CNT=16
EB_ARGS="--include-easyblocks-from-pr 3373 --installpath /tmp/$USER/pr20902"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=20902 EB_ARGS="--include-easyblocks-from-pr 3373 --installpath /tmp/$USER/pr20902" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20902 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13985

Test results coming soon (I hope)...

- notification for comment with ID 2260799985 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Crivella
Copy link
Contributor Author

@boegel
Is it normal the job has been there for 2 weeks? Just to make sure the build process is not stuck somewhere and wasting resources

@branfosj
Copy link
Member

ERROR: Missing dependencies: lit/18.1.2-GCCcore-12.2.0, git/2.42-GCCcore-13.2.0 (no easyconfig file or existing module found)

@Crivella
Copy link
Contributor Author

@branfosj Thanks! I've fixed this with 6d35631

@branfosj
Copy link
Member

@boegelbot please test @ generoso
CORE_CNT=16
EB_ARGS="--include-easyblocks-from-pr 3373 --installpath /tmp/$USER/pr20902"

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=20902 EB_ARGS="--include-easyblocks-from-pr 3373 --installpath /tmp/$USER/pr20902" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20902 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14052

Test results coming soon (I hope)...

- notification for comment with ID 2285756812 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3373
FAILED
Build succeeded for 16 out of 21 (21 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/5d2fa9a94fea54443c6efb24cd74661b for a full test report.

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=20902 EB_ARGS="LLVM-12.0.1-GCCcore-11.2.0.eb LLVM-14.0.3-GCCcore-11.3.0.eb LLVM-14.0.6-GCCcore-12.2.0-llvmlite.eb LLVM-14.0.6-GCCcore-12.3.0-llvmlite.eb LLVM-14.0.6-GCCcore-13.2.0-llvmlite.eb LLVM-15.0.5-GCCcore-12.2.0.eb LLVM-16.0.6-GCCcore-12.3.0.eb LLVM-16.0.6-GCCcore-13.2.0.eb LLVM-18.1.8-GCCcore-13.3.0-minimal.eb --include-easyblocks-from-pr 3373" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_20902 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5896

Test results coming soon (I hope)...

- notification for comment with ID 2704250151 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3373
FAILED
Build succeeded for 8 out of 14 (9 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/47629276a73338f90a6cde3676e293a2 for a full test report.

@boegel
Copy link
Member

boegel commented Mar 6, 2025

Hmm, pretty consistent small group of tests that failed with bot:

Failed Tests (6):
  LLVM :: tools/llvm-mt/big_merge.test
  LLVM :: tools/llvm-mt/conflicting.test
  LLVM :: tools/llvm-mt/notify_update.test
  LLVM :: tools/llvm-mt/simple_merge.test
  LLVM :: tools/llvm-mt/single_file.test
  LLVM :: tools/llvm-mt/xml_error.test

Not sure what can cause these, they didn't pop up before.

@Crivella I won't let this block the merge of easybuilders/easybuild-easyblocks#3373 + this PR, but we should maybe follow up on this?

@Crivella
Copy link
Contributor Author

Crivella commented Mar 6, 2025

I will check on them tomorrow, but i do not think they are extremely relevant (seems to be only a problem with the tool llvm-mt)

@boegel
Copy link
Member

boegel commented Mar 6, 2025

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3373
FAILED
Build succeeded for 19 out of 20 (20 easyconfigs in total)
node3506.doduo.os - Linux Rocky Linux 8.10, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/3046b058f9552bfe638d56b83721ec52 for a full test report.

@boegel
Copy link
Member

boegel commented Mar 7, 2025

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3373
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
node3623.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/30ecfa7426fab72e5bd2198e7d348f5e for a full test report.

@boegel
Copy link
Member

boegel commented Mar 7, 2025

Test build for LLVM/18.1.8-GCCcore-13.3.0-minimal in Rocky Linux 8.10 container failed with:

cmake: error while loading shared libraries: libssl.so.3: cannot open shared object file: No such file or directory

That's entirely my bad, there is not OpenSSL 3 in that containers and I was reusing a bunch of modules...

I'll upload a new test report for that one easyconfigs, and then this is good to go... \o/

@boegel boegel changed the title {compiler}[SYSTEM,GCCcore/13.3.0] LLVM core fix LLVM easyconfigs as required by revamped custom easyblock for LLVM + add lit and git as build dependencies Mar 7, 2025
boegel
boegel previously approved these changes Mar 7, 2025
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extensively tested with easybuilders/easybuild-easyblocks#3373, so time to finally merge this.

@Crivella Thanks a lot for all your efforts on this, and sorry for the holdup...

@boegel
Copy link
Member

boegel commented Mar 7, 2025

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3373
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3506.doduo.os - Linux Rocky Linux 8.10, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/70a222efa6817f148396e32fc363682a for a full test report.

@boegel
Copy link
Member

boegel commented Mar 7, 2025

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3623.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/b9cd59dc76efb68f646ec1d12d6b9328 for a full test report.

@Crivella
Copy link
Contributor Author

Crivella commented Mar 7, 2025

I think the failure in the CI was due to Mesa-24.1.3 depending on LLVM-18.1.8-GCCcore-13.3.0 which has now been suffixed with minimal

I've updated the dependency in 66b29d9

@Thyre
Copy link
Contributor

Thyre commented Mar 7, 2025

Is there a reason why we have both easybuild/easyconfigs/l/lit/lit-18.1.7-GCCcore-13.3.0.eb and easybuild/easyconfigs/l/lit/lit-18.1.8-GCCcore-13.3.0.eb for GCCcore/13.3.0? easybuild/easyconfigs/l/LLVM/LLVM-18.1.8-GCCcore-13.3.0-minimal.eb is only using the latter.

@Crivella
Copy link
Contributor Author

Crivella commented Mar 7, 2025

Umh, i think it is a leftover from the fact that i first build around 18.1.7 and than updated to 18.1.8.
It does not seems to still be used so it can probably be removed (or just left there in case someone would ever want it)

@boegel
Copy link
Member

boegel commented Mar 7, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3623.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/0582b42046cb9eb598a4df265fce6ba4 for a full test report.

@boegel
Copy link
Member

boegel commented Mar 7, 2025

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3621.doduo.os - Linux Rocky Linux 8.10, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/e20a5f3be17311f8a26729d9a55ca585 for a full test report.

@boegel boegel added this to the 5.0.0 milestone Mar 8, 2025
@boegel
Copy link
Member

boegel commented Mar 8, 2025

Going in, thanks @Crivella!

@boegel boegel merged commit a90842d into easybuilders:5.0.x Mar 8, 2025
8 checks passed
@Crivella Crivella deleted the feature-LLVM_unified branch March 10, 2025 09:13
Crivella added a commit to Crivella/easybuild-easyconfigs that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants