Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{tools}[foss/2023a] Optuna v3.5.0 #20264

Merged

Conversation

ThomasHoffmann77
Copy link
Contributor

(created using eb --new-pr)

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Apr 3, 2024

@boegelbot please test @ jsc-zen3

@Micket
Copy link
Contributor

Micket commented Apr 3, 2024

I only just now realized this wasn't using CUDA. Does it generate CUDA code or something, so maybe it doesn't use CUDA at build time? I'm just a bit confused.

@Micket
Copy link
Contributor

Micket commented Apr 3, 2024

Test report by @Micket
SUCCESS
Build succeeded for 6 out of 6 (4 easyconfigs in total)
vera40-1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, 1 x NVIDIA Tesla T4, 550.54.14, Python 3.6.8
See https://gist.github.com/Micket/166d274983fd3499ae0104e5d145d929 for a full test report.

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20264 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20264 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3913

Test results coming soon (I hope)...

- notification for comment with ID 2034869651 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/ae2d14e98617e13840b387db000b1ffe for a full test report.

@Micket
Copy link
Contributor

Micket commented Apr 3, 2024

Just loading Optuna and it works with CuPy directly, so i'm not sure we need to add this as a strict dep to CuPy, it can be opt-in at no loss for those who actually want to optimize the code evaluation i guess.

@Micket
Copy link
Contributor

Micket commented Apr 3, 2024

@boegelbot please test @ generoso

@Micket
Copy link
Contributor

Micket commented Apr 3, 2024

Going in, thanks @ThomasHoffmann77!

@Micket Micket merged commit 9a653b4 into easybuilders:develop Apr 3, 2024
9 checks passed
@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=20264 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20264 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13249

Test results coming soon (I hope)...

- notification for comment with ID 2035201114 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/70cdeffa1d8e8b67e8d748a9688e23a7 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants