Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix configure option and remove gperftools dependency for MIRA 5.0 #20061

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Mar 7, 2024

(created using eb --new-pr)

with-tcmalloc-dir doesn't exist and 4.9.4 changelog shows:

MIRA does not link per default to TCMalloc library anymore.

Even after build with the gperftools dependency I couldn't find any reference to it in the install tree or configure log

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
n1358 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/974da5bc15b8492eac5b2eed2cb560df for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Mar 7, 2024

@boegelbot please test @ generoso

@Micket Micket added the bug fix label Mar 7, 2024
@Micket Micket added this to the release after 4.9.0 milestone Mar 7, 2024
@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=20061 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20061 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13050

Test results coming soon (I hope)...

- notification for comment with ID 1984764779 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/42f97df86fb7321da5c6382a47cfffcc for a full test report.

@Micket
Copy link
Contributor

Micket commented Mar 11, 2024

Going in, thanks @Flamefire!

@Micket Micket merged commit 247b3a8 into easybuilders:develop Mar 11, 2024
9 checks passed
@Flamefire Flamefire deleted the 20240307090543_new_pr_MIRA50rc2 branch March 11, 2024 12:12
@boegel boegel changed the title Fix configure option and gpertools dependency of MIRA 5.0 Fix configure option and gperftools dependency of MIRA 5.0 Apr 4, 2024
@boegel boegel changed the title Fix configure option and gperftools dependency of MIRA 5.0 fix configure option and remove gperftools dependency for MIRA 5.0 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants