-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop using non-existent --disable-libdeflate
option for LibTIFF 4.1.0
#19951
stop using non-existent --disable-libdeflate
option for LibTIFF 4.1.0
#19951
Conversation
Test report by @Flamefire |
@boegelbot: please test @ generoso |
@jfgrimm: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1959671800 processed Message to humans: this is just bookkeeping information for me, |
Test report by @jfgrimm |
Test report by @boegelbot |
@boegelbot: please test @ jsc-zen3 |
@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1959726275 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
failures on jsc-zen3 look to be due to bootstrapping old compilers on a newer OS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @Flamefire! |
--disable-libdeflate
option for LibTIFF 4.1.0
(created using
eb --new-pr
)That option was added in 4.2.0 see https://gitlab.com/libtiff/libtiff/-/commit/3a2de853a932bd0ea79d1677d319841edb736c38
But it was wrongly added to the ECs in #14079