Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing SciPy-bundle dependency to TensorRT easyconfig #19486

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Jan 3, 2024

(created using eb --new-pr)
without this, pip check fails with: uff 0.6.9 requires numpy, which is not installed

@boegel
Copy link
Member Author

boegel commented Jan 3, 2024

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3022
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3608.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/40bc543aa1ce3d4380b9147f42d89912 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Jan 3, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jan 3, 2024
@boegel
Copy link
Member Author

boegel commented Jan 3, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19486 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19486 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12492

Test results coming soon (I hope)...

- notification for comment with ID 1876042083 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f6803bb488d94e4630970e175d1c703d for a full test report.

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 6433e81 into easybuilders:develop Jan 4, 2024
9 checks passed
@boegel boegel deleted the 20240103210834_new_pr_TensorRT861 branch January 4, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants