Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable -fPIC in easyconfig for libwebp 1.3.2 #19098

Merged

Conversation

Micket
Copy link
Contributor

@Micket Micket commented Oct 27, 2023

(created using eb --new-pr)

Found it i needed this to be able to link an application to the static libwebp library.

@Micket Micket added the bug fix label Oct 27, 2023
@Micket Micket added this to the next release (4.8.2) milestone Oct 27, 2023
@Micket
Copy link
Contributor Author

Micket commented Oct 27, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=19098 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19098 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12071

Test results coming soon (I hope)...

- notification for comment with ID 1783341837 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/b481549c6793da345b65703c120191f2 for a full test report.

@Micket
Copy link
Contributor Author

Micket commented Oct 27, 2023

@boegelbot please test @ jsc-zen2

@Micket
Copy link
Contributor Author

Micket commented Oct 27, 2023

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-c1 - Linux Rocky Linux 8.8, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/b5034636cb5ef455d5f5abc4baa0c9a5 for a full test report.

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19098 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19098 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3652

Test results coming soon (I hope)...

- notification for comment with ID 1783360112 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/c60c3556ba7554e8a9b8cb681524a82e for a full test report.

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa merged commit fc370cc into easybuilders:develop Oct 27, 2023
@boegel boegel changed the title Enable PIC in recent libwebp build enable PIC in recent libwebp easyconfig Oct 27, 2023
@boegel boegel changed the title enable PIC in recent libwebp easyconfig enable -fPIC in easyconfig for libwebp 1.3.2 Oct 29, 2023
@Micket Micket deleted the 20231027202904_new_pr_libwebp132 branch October 30, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants