-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove numa configure option from hwloc 2.5+ #19085
remove numa configure option from hwloc 2.5+ #19085
Conversation
Test report by @Flamefire |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1876753130 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @boegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @Flamefire! |
(created using
eb --new-pr
)Hwloc removed the libnuma dependency in 2.0.0 and with it the
--enable-libnuma
optionWe could remove the
numactl
dependency as well but I didn't wanted to change it to much, just avoid the configure warning (unknown option). But libnuma seems to be used (sometimes?) in the tests: https://github.com/open-mpi/hwloc/blob/a1b939190938ac253d4ba27328445b61258320c8/config/hwloc_internal.m4#L424-L434, so numctl could be downgraded to a builddependencyFurthermore I restricted the changes to hwloc 2.5+ corresponding the GCC 11.2+ in our toolchains. The same change can be applied to the older ECs too if wanted.