Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only add tbb as dependency in recent LAMMPS easyconfigs when installing on x86_64 #19000

Merged
merged 4 commits into from
Oct 13, 2023
Merged

only add tbb as dependency in recent LAMMPS easyconfigs when installing on x86_64 #19000

merged 4 commits into from
Oct 13, 2023

Conversation

laraPPr
Copy link
Contributor

@laraPPr laraPPr commented Oct 12, 2023

(created using eb --new-pr)

@laraPPr
Copy link
Contributor Author

laraPPr commented Oct 12, 2023

Test report by @laraPPr
FAILED
Build succeeded for 2 out of 3 (3 easyconfigs in total)
node4010.donphan.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz, 1 x NVIDIA NVIDIA A2, 535.104.12, Python 3.6.8
See https://gist.github.com/laraPPr/a8370956aa754b9d6cd8c51a0c7473c6 for a full test report.

@laraPPr
Copy link
Contributor Author

laraPPr commented Oct 12, 2023

Test report by @laraPPr
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node4010.donphan.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz, 1 x NVIDIA NVIDIA A2, 535.104.12, Python 3.6.8
See https://gist.github.com/laraPPr/1dff13807f6a9cdd6eb1583179dc0181 for a full test report.

@laraPPr
Copy link
Contributor Author

laraPPr commented Oct 12, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@laraPPr: Request for testing this PR well received on login1

PR test command 'EB_PR=19000 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19000 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11925

Test results coming soon (I hope)...

- notification for comment with ID 1759587288 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@laraPPr laraPPr mentioned this pull request Oct 12, 2023
Merged
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/3f5bc4fd00d481cf875f0074df762de8 for a full test report.

@laraPPr
Copy link
Contributor Author

laraPPr commented Oct 12, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@laraPPr: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19000 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19000 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3537

Test results coming soon (I hope)...

- notification for comment with ID 1759758399 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/936072481cde6aaa211f0d1f73d15ffa for a full test report.

@smoors
Copy link
Contributor

smoors commented Oct 13, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=19000 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19000 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11934

Test results coming soon (I hope)...

- notification for comment with ID 1761222417 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6ec494fdd25b7015dfd0d8c3eb90e0f7 for a full test report.

@smoors
Copy link
Contributor

smoors commented Oct 13, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19000 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19000 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3550

Test results coming soon (I hope)...

- notification for comment with ID 1761338122 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/e1df4dad2f9011a3356c787f526faf0b for a full test report.

smoors
smoors approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the next release (4.8.2?) milestone Oct 13, 2023
@smoors
Copy link
Contributor

smoors commented Oct 13, 2023

Going in, thanks @laraPPr!

@smoors smoors merged commit f977b81 into easybuilders:develop Oct 13, 2023
@boegel boegel added bug fix EESSI Related to EESSI project labels Oct 18, 2023
@boegel boegel changed the title TBB is optional dependency when building on Intel arch only add tbb as dependency in recent LAMMPS easyconfigs when installing on an x86_64 system Oct 18, 2023
@boegel boegel changed the title only add tbb as dependency in recent LAMMPS easyconfigs when installing on an x86_64 system only add tbb as dependency in recent LAMMPS easyconfigs when installing on x86_64 Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoors smoors smoors approved these changes

Assignees
No one assigned
Labels
bug fix EESSI Related to EESSI project
Projects
None yet
Milestone
4.8.2
Development

Successfully merging this pull request may close these issues.
4 participants
@laraPPr @boegelbot @smoors @boegel