Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch to fix issue with automatic detection of NeoverseV1 CPU architecture in OpenBLAS v0.3.20 #18870

Merged
merged 4 commits into from
Sep 26, 2023
Merged

add patch to fix issue with automatic detection of NeoverseV1 CPU architecture in OpenBLAS v0.3.20 #18870

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
226a097
Fixes issue with automatic detection of NeoverseV1 architecture at bu…
Sep 26, 2023
1b7723a
Fix patch description
Sep 26, 2023
8205d98
fix long line in OpenBLAS 0.3.20 easyconfig
boegel Sep 26, 2023
1081c81
strip off trailing whitespace
boegel Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions easybuild/easyconfigs/o/OpenBLAS/OpenBLAS-0.3.20-GCC-11.3.0.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ patches = [
'OpenBLAS-0.3.21_fix-order-vectorization.patch',
'OpenBLAS-0.3.21_disable-fma-in-cscal-zscal.patch',
'OpenBLAS-0.3.21_avoid-crash-in-zdot.patch',
'OpenBLAS-0.3.20_fix-cpuid-neoverse-v1-n2.patch',
]
checksums = [
{'v0.3.20.tar.gz': '8495c9affc536253648e942908e88e097f2ec7753ede55aca52e5dead3029e3c'},
Expand All @@ -31,6 +32,8 @@ checksums = [
{'OpenBLAS-0.3.21_disable-fma-in-cscal-zscal.patch':
'bd6836206a883208dc8bc997946f97e4c97d91d8e101fc54db414aaa56902fc3'},
{'OpenBLAS-0.3.21_avoid-crash-in-zdot.patch': '3dac2c1ec896df574f1b37cde81a16f24550b7f1eb81fbfacb0c4449b0dc7894'},
{'OpenBLAS-0.3.20_fix-cpuid-neoverse-v1-n2.patch':
'1b495465f8dd1e151d74cf5aa4288120361d29164d6a377228a8d51c255b8a9e'},
]

builddependencies = [
Expand Down
17 changes: 17 additions & 0 deletions easybuild/easyconfigs/o/OpenBLAS/OpenBLAS-0.3.20_fix-cpuid-neoverse-v1-n2.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# This fixes an incorrect autodetection of NeoverseV1 architecture at build time
# Fixes https://github.com/EESSI/software-layer/pull/310#issuecomment-1734345487
casparvl marked this conversation as resolved.
Show resolved Hide resolved
# Patch was extracted from https://github.com/OpenMathLib/OpenBLAS/commit/09b8545fc51316d0fecf34c9e753b8a20358a3e8
# which is part of https://github.com/OpenMathLib/OpenBLAS/pull/3586 (which is merged in OpenBLAS-0.3.21)
--- cpuid_arm64.c.orig 2022-02-20 21:35:05.000000000 +0000
+++ cpuid_arm64.c 2023-09-26 16:27:15.265602255 +0000
@@ -73,8 +73,8 @@
"TSV110",
"EMAG8180",
"NEOVERSEN1",
- "NEOVERSEV1"
- "NEOVERSEN2"
+ "NEOVERSEV1",
+ "NEOVERSEN2",
"THUNDERX3T110",
"VORTEX",
"CORTEXA55",