-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{lang}[GCCcore/12.3.0] Rust v1.70.0 #18016
{lang}[GCCcore/12.3.0] Rust v1.70.0 #18016
Conversation
Test report by @Micket |
bah, they completely changed the logic in the bootstrap.py stuff. I'll see if what i can do with the patch |
@boegelbot please test @ generoso |
@Micket: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1574940623 processed Message to humans: this is just bookkeeping information for me, |
@boegelbot please test @ jsc-zen2 |
@Micket: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1574958932 processed Message to humans: this is just bookkeeping information for me, |
Test report by @Micket |
Test report by @boegelbot |
Test report by @boegelbot |
Test report by @boegel |
Test report by @boegel |
Test report by @branfosj |
Test report by @boegel |
Looks like some possible issue with cmake on debian?
I don't see how, since we do have zlib as a dep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
It's a problem when installing CMake in an environment with an alternate sysroot, like we're doing in EESSI. Debian is the build container we use, but the test report basically for the EESSI build environmen, we should make EasyBuild aware of that. |
Test report by @boegel edit: test report from EESSI 2023.04 build environment |
Test report by @Micket |
@Micket Test install in EESSI environment failed, looks like the patch needs work?
|
Test report by @boegel |
Test report by @boegel |
fix sysroot patch for Rust 1.70.0
Test report by @branfosj |
Test report by @boegel edit: test report from EESSI 2023.04 build environment |
Test report by @casparvl |
The best way to deal with the RPATH issue here is probably to create a custom easyblock for Rust, where we use @casparvl Thoughts on that? |
So... why is If it's compiled, we should figure out why it sets The big issue with fixing this programmatically in the EasyBlock is that we'd need to make sure a It would be useful if we could come up with a good patch-on-the-fly strategy from EasyBlocks in general btw. Maybe not for this particular case (if it's indeed a |
I had a quick look. This library doesn't seem to come with the sources, but in the logs (even with I'll check if I can easily pass the |
From the
That sounds like it is distributed as a binary, and not compiled...? |
Ok, I'm now 99% sure this is just installed as a binary:
And, on the installed library, I get the same checksum:
That means indeed the only way to 'fix' this, is to |
Ok, I wrote my thoughts regarding the I don't think it should be blocking this PR thought: useage of |
@casparvl I'm fine with merging this PR as-is for now, and dealing with the RPATH issue in a follow-up PR. W.r.t. the easyblock proposal: we could easily always list a specific version The custom easyblock for Rust that would rely on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @Micket! |
(created using
eb --new-pr
)requires: