-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add patch to fix test_quantization in PyTorch 1.12.1 #17908
add patch to fix test_quantization in PyTorch 1.12.1 #17908
Conversation
49c34f4
to
cff9985
Compare
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1559634074 processed Message to humans: this is just bookkeeping information for me, |
@boegelbot please test @ jsc-zen2 |
@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1559649652 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @boegel |
Going in, thanks @Flamefire! |
Test report by @boegel |
(created using
eb --new-pr
)This should fix the failure reported by @boegel at #17615 (comment) using the proposal of @branfosj which I verified is correct: That flag is set globally by https://github.com/pytorch/pytorch/blob/9b6ccde0e6408cbef9029bd593dfba7ab6b39ca6/torch/testing/_internal/common_utils.py#L1733 but the decorator replaces ALL flags so that global one has to be specified too.
I updated all 1.12.1 ECs, but I guess checking the failing one should be enough.