Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch to fix test_quantization in PyTorch 1.12.1 #17908

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented May 15, 2023

(created using eb --new-pr)

This should fix the failure reported by @boegel at #17615 (comment) using the proposal of @branfosj which I verified is correct: That flag is set globally by https://github.com/pytorch/pytorch/blob/9b6ccde0e6408cbef9029bd593dfba7ab6b39ca6/torch/testing/_internal/common_utils.py#L1733 but the decorator replaces ALL flags so that global one has to be specified too.

I updated all 1.12.1 ECs, but I guess checking the failing one should be enough.

@Flamefire Flamefire force-pushed the 20230515172521_new_pr_PyTorch1121 branch from 49c34f4 to cff9985 Compare May 23, 2023 07:36
@boegel boegel changed the title fix test_quantization in PyTorch 1.12.1 add patch to fix test_quantization in PyTorch 1.12.1 May 23, 2023
@boegel
Copy link
Member

boegel commented May 23, 2023

@boegelbot please test @ generoso
CORE_CNT=16
EB_ARGS="PyTorch-1.12.1-foss-2021a.eb"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=17908 EB_ARGS="PyTorch-1.12.1-foss-2021a.eb" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17908 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10849

Test results coming soon (I hope)...

- notification for comment with ID 1559634074 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel boegel added the bug fix label May 23, 2023
@boegel boegel added this to the next release (4.7.2) milestone May 23, 2023
@boegel
Copy link
Member

boegel commented May 23, 2023

@boegelbot please test @ jsc-zen2
CORE_CNT=16
EB_ARGS="PyTorch-1.12.1-foss-2022a.eb"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17908 EB_ARGS="PyTorch-1.12.1-foss-2022a.eb" /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17908 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2656

Test results coming soon (I hope)...

- notification for comment with ID 1559649652 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2g1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/a49b56a7ac3bfc9e0cc443750ba1da11 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/5a9a86cf07db74a507407475f46180b9 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented May 24, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3309.joltik.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), 1 x NVIDIA Tesla V100-SXM2-32GB, 530.30.02, Python 3.6.8
See https://gist.github.com/boegel/0512cb9fa1d4845a20c7d65e384ad820 for a full test report.

@boegel
Copy link
Member

boegel commented May 24, 2023

Going in, thanks @Flamefire!

@boegel boegel merged commit 37766c4 into easybuilders:develop May 24, 2023
@Flamefire Flamefire deleted the 20230515172521_new_pr_PyTorch1121 branch May 24, 2023 10:35
@boegel
Copy link
Member

boegel commented May 25, 2023

Test report by @boegel
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in total)
node3904.accelgor.os - Linux RHEL 8.6, x86_64, AMD EPYC 7413 24-Core Processor (zen3), 1 x NVIDIA NVIDIA A100-SXM4-80GB, 530.30.02, Python 3.6.8
See https://gist.github.com/boegel/56ed7fd2edab9568891195e1e4335a9d for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants