Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update easyconfig for Longshot 0.4.5 to use Cargo easyblock #17666

Merged
merged 2 commits into from
May 24, 2023

Conversation

@Micket Micket added the change label Apr 8, 2023
@Micket
Copy link
Contributor Author

Micket commented Apr 8, 2023

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 2902"

@Micket
Copy link
Contributor Author

Micket commented Apr 8, 2023

Test report by @Micket
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2902
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-c1 - Linux Rocky Linux 8.6, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/1dd622d9911303ea5047fb41d85b120e for a full test report.

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=17666 EB_ARGS="--include-easyblocks-from-pr 2902" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17666 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10608

Test results coming soon (I hope)...

- notification for comment with ID 1500911989 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2902
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/5600f0e1289f002a250ed647ff66080f for a full test report.

@boegel boegel changed the title New Longshot using Cargo easyblock update easyconfig for Longshot 0.4.5 to use Cargo easyblock Apr 12, 2023
@Micket
Copy link
Contributor Author

Micket commented Apr 13, 2023

Test report by @Micket
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2902
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-c1 - Linux Rocky Linux 8.6, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/8481593bceab3a126350755cf5f49b2e for a full test report.

@Micket
Copy link
Contributor Author

Micket commented May 10, 2023

Test report by @Micket
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2902
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-c1 - Linux Rocky Linux 8.7, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/0ffb99399366eefd10771a675038c497 for a full test report.

@Micket
Copy link
Contributor Author

Micket commented May 10, 2023

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 2902"

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=17666 EB_ARGS="--include-easyblocks-from-pr 2902" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17666 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10774

Test results coming soon (I hope)...

- notification for comment with ID 1542512130 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2902
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/badcef0a6c60122220f46c41e6fd11b6 for a full test report.

@boegel boegel added this to the next release (4.7.2) milestone May 23, 2023
@boegel
Copy link
Member

boegel commented May 23, 2023

@boegelbot please test @ jsc-zen2
EB_ARGS="--include-easyblocks-from-pr 2902"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17666 EB_ARGS="--include-easyblocks-from-pr 2902" /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17666 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2657

Test results coming soon (I hope)...

- notification for comment with ID 1559771523 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2902
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/01941817363ad988ad8d780692e5280d for a full test report.

@Micket
Copy link
Contributor Author

Micket commented May 23, 2023

ok so, this is that march thing on jsc-zen2 again

error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `rustc - --crate-name ___ --print=file-names -C 'target-cpu={'\''Intel'\'':' ''\''march=core-avx2'\''}' --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg` (exit status: 1)
  --- stderr
  error: multiple input filenames provided (first two filenames are `-` and `'march=core-avx2'}`)

just like with easybuilders/easybuild-easyblocks#2759

I'm not sure what i should do with that a dictionary here..

1 similar comment
@Micket
Copy link
Contributor Author

Micket commented May 23, 2023

ok so, this is that march thing on jsc-zen2 again

error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `rustc - --crate-name ___ --print=file-names -C 'target-cpu={'\''Intel'\'':' ''\''march=core-avx2'\''}' --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg` (exit status: 1)
  --- stderr
  error: multiple input filenames provided (first two filenames are `-` and `'march=core-avx2'}`)

just like with easybuilders/easybuild-easyblocks#2759

I'm not sure what i should do with that a dictionary here..

@boegel
Copy link
Member

boegel commented May 23, 2023

@Micket Let's open an issue on that in the easyblocks repo, we may need to come up with a general approach there that works for OpenCV too...

@boegel
Copy link
Member

boegel commented May 23, 2023

@boegelbot please test @ jsc-zen2
EB_ARGS="--optarch='' --include-easyblocks-from-pr 2902"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17666 EB_ARGS="--optarch='' --include-easyblocks-from-pr 2902" /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17666 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2659

Test results coming soon (I hope)...

- notification for comment with ID 1559797539 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2902
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/47598c4616c231ce5f986cefa32edf18 for a full test report.

@Micket
Copy link
Contributor Author

Micket commented May 23, 2023

'''' is not a recognized processor for this target (ignoring processor)

i guess it's assigning a empty string. I can't tell what RUSTFLAS is assigned from that partial log

I would have thought this could be enough to protect against None or empty strings?

        optarch = build_option('optarch')
        if not optarch:
            optarch = 'native'
        env.setvar('RUSTFLAGS', '-C target-cpu=%s' % optarch

@boegel
Copy link
Member

boegel commented May 23, 2023

@Micket ' ' (single space) is not an empty string, and evaluates to True?

@boegel
Copy link
Member

boegel commented May 23, 2023

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2902
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3165.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/7554637214c10cab6fe1abd3dd9bc2dc for a full test report.

@Micket
Copy link
Contributor Author

Micket commented May 23, 2023

@Micket ' ' (single space) is not an empty string, and evaluates to True?

yes but that's not what we have here? Not indicated by the error message either.
I'd like to get the full log from jsc-zen2 to see what the environment variables actually are set to

Running a local

eb --optarch='' Longshot-0.4.5-GCCcore-11.3.0.eb --rebuild

i have no issues.

@boegel
Copy link
Member

boegel commented May 24, 2023

@boegelbot please test @ jsc-zen2
EB_ARGS="--logtostdout --debug --optarch='' --include-easyblocks-from-pr 2902"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17666 EB_ARGS="--logtostdout --debug --optarch='' --include-easyblocks-from-pr 2902" /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17666 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2661

Test results coming soon (I hope)...

- notification for comment with ID 1560513283 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2902
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/0a93ca0a1a2481856efbcffa104cf052 for a full test report.

@boegel
Copy link
Member

boegel commented May 24, 2023

@Micket It works fine if I use --optarch='' manually on jsc-zen2, so it has something to do with how the bot picks up EB_ARGS from the comment...

@boegel
Copy link
Member

boegel commented May 24, 2023

Ah, here's the problem, the single quotes are escaped:

== 2023-05-24 06:17:13,131 generaloption.py:1696 DEBUG generate_cmd_line adding optarch value ''

So the correct way is to use --optarch=, let's try that

@boegel
Copy link
Member

boegel commented May 24, 2023

@boegelbot please test @ jsc-zen2
EB_ARGS="--optarch= --include-easyblocks-from-pr 2902"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17666 EB_ARGS="--optarch= --include-easyblocks-from-pr 2902" /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17666 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2662

Test results coming soon (I hope)...

- notification for comment with ID 1560526731 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2902
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/5854fdad26f13cfa9fdedb915993af4c for a full test report.

@boegel
Copy link
Member

boegel commented May 24, 2023

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 2934"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=17666 EB_ARGS="--include-easyblocks-from-pr 2934" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17666 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10867

Test results coming soon (I hope)...

- notification for comment with ID 1561321192 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2934
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns4 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/fb8516c00d6c8c3ce9680813d7964623 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented May 24, 2023

Going in, thanks @Micket!

@boegel boegel merged commit 3b1c4ae into easybuilders:develop May 24, 2023
@Micket Micket deleted the 20230405132523_new_pr_Longshot045 branch October 11, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants