Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix configure step for ELSI 2.5.0+ (and add missing foss versions) #17288

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Feb 9, 2023

(created using eb --new-pr)

fixes #17259

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
taurusi6607.taurus.hrsk.tu-dresden.de - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/c6408759d6854d0bd84c3ea38d5e0707 for a full test report.

@boegel
Copy link
Member

boegel commented Feb 9, 2023

@boegelbot please test @ generoso

@boegel boegel added the update label Feb 9, 2023
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=17288 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17288 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10137

Test results coming soon (I hope)...

- notification for comment with ID 1424876569 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 6 out of 9 (8 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/7c61c609566976be767fd69f6a62ac60 for a full test report.

@Flamefire
Copy link
Contributor Author

@boegel I see the same (or similar, not sure) errors during the tests so I disabled testing for my reports as the build is what was broken and manual investigation shows the correct compilers were used as far as I could tell.

@boegel boegel changed the title Fix ELSI build and add missing foss versions fix configure step for ELSI 2.5.0+ (and add missing foss versions) Mar 15, 2023
@boegel boegel changed the title fix configure step for ELSI 2.5.0+ (and add missing foss versions) fix configure step for ELSI 2.5.0+ (and add missing foss versions) Mar 15, 2023
@boegel boegel modified the milestones: 4.7.1, release after 4.7.1 Mar 19, 2023
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going through everything marked for 4.7.2

Two of the 2019b failures comes from missing MUMPS module, which, i'm really not sure what happened. Something must be broken in the module tree on generoso, or someone was rebuilding those ancient MUMPS packages at the same time, which seems unlikely. The last failure is the PEXSI variant which had a lot of segfaults.

2019b is to old for my own test tree, and I really don't think we want to hold back on the fixes for the more recent easyconfigs as a result of those old broken ones, which almost certainly were broken before this PR as far as i can tell.
I'm willing to accept this PR as is.

@Micket
Copy link
Contributor

Micket commented Apr 18, 2023

Test report by @Micket
SUCCESS
Build succeeded for 6 out of 6 (2 easyconfigs in total)
vera-c1 - Linux Rocky Linux 8.6, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/b3087679e1877f0a5b0a2387003aa4a1 for a full test report.

@Micket
Copy link
Contributor

Micket commented Apr 18, 2023

Going in, thanks @Flamefire!

@Micket Micket merged commit 66ba7d1 into easybuilders:develop Apr 18, 2023
@Flamefire Flamefire deleted the 20230209164825_new_pr_ELSI250 branch April 18, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ELSI fails to build with latest EasyBuild releases
4 participants