Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sanity check command to OpenMolcas v22.10 #17128

Merged
merged 2 commits into from
Jan 18, 2023
Merged

add sanity check command to OpenMolcas v22.10 #17128

merged 2 commits into from
Jan 18, 2023

Conversation

sassy-crick
Copy link
Collaborator

(created using eb --new-pr)

@sassy-crick sassy-crick changed the title Test jobs enabled else similar to PR 16770 {chem}[intel/2022a] OpenMolcas v22.10 w/ Python 3.10.4 Jan 17, 2023
@sassy-crick
Copy link
Collaborator Author

Unlike PR #16770 here the test jobs are actually enabled.

lexming
lexming requested changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please apply these changes (adding the execution of tests) to OpenMolcas-22.10-intel-2022a-noGA.eb as well?

easybuild/easyconfigs/o/OpenMolcas/OpenMolcas-22.10-intel-2022a.eb Outdated Show resolved Hide resolved
easybuild/easyconfigs/o/OpenMolcas/OpenMolcas-22.10-intel-2022a.eb Outdated Show resolved Hide resolved
easybuild/easyconfigs/o/OpenMolcas/OpenMolcas-22.10-intel-2022a.eb Outdated Show resolved Hide resolved
@lexming
Copy link
Contributor

lexming commented Jan 18, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=17128 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17128 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10027

Test results coming soon (I hope)...

- notification for comment with ID 1387257498 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@lexming lexming changed the title {chem}[intel/2022a] OpenMolcas v22.10 w/ Python 3.10.4 {chem}[intel/2022a] add sanity check command to OpenMolcas v22.10 Jan 18, 2023
@lexming lexming added this to the next release (4.7.1?) milestone Jan 18, 2023
@boegel boegel changed the title {chem}[intel/2022a] add sanity check command to OpenMolcas v22.10 add sanity check command to OpenMolcas v22.10 Jan 18, 2023
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/2ca64b1e521090e7909ebb22d2c2058b for a full test report.

lexming
lexming approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Jan 18, 2023

Going in, thanks @sassy-crick !

@lexming lexming merged commit 508b155 into easybuilders:develop Jan 18, 2023
@boegel boegel mentioned this pull request Jan 21, 2023
Open
@boegel
Copy link
Member

boegel commented Jan 21, 2023

This should have been tested a bit more it seems, see #17174

@sassy-crick sassy-crick deleted the 20230117105112_new_pr_OpenMolcas2210 branch January 30, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexming lexming lexming approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@sassy-crick @lexming @boegelbot @boegel