Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing pyWannier90 dependency for mcu + enhance sanity check #16667

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 16, 2022

(created using eb --new-pr)

@boegel boegel added the bug fix label Nov 16, 2022
@boegel boegel added this to the next release (4.6.3?) milestone Nov 16, 2022
@boegel
Copy link
Member Author

boegel commented Nov 16, 2022

@boegelbot please test @ generoso

@boegel
Copy link
Member Author

boegel commented Nov 16, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3151.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/c26276d81ba319f45c820f4293df8e9d for a full test report.

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16667 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16667 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9535

Test results coming soon (I hope)...

- notification for comment with ID 1317519990 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/778ca6b7ade76edfc3b503a8d2b4710c for a full test report.

Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Nov 17, 2022

Going in, thanks @boegel !

@lexming lexming merged commit 6263623 into easybuilders:develop Nov 17, 2022
@boegel boegel deleted the 20221116183139_new_pr_mcu20210406 branch November 23, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants