Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing patches for AmberTools 21 with intel/2021b toolchain + enable running tests #16152

Merged

Conversation

akesandgren
Copy link
Contributor

@akesandgren akesandgren commented Aug 29, 2022

(created using eb --new-pr)

Depends on easybuilders/easybuild-easyblocks#2781

@akesandgren akesandgren changed the title fix top level Makefile for AmberTools 21 fix top level Makefile for AmberTools 21 for intel Aug 29, 2022
@akesandgren akesandgren added this to the 4.x milestone Aug 29, 2022
@easybuilders easybuilders deleted a comment from boegelbot Aug 30, 2022
@akesandgren
Copy link
Contributor Author

@boegelbot Please test @ generoso

@boegelbot
Copy link
Collaborator

@akesandgren: Request for testing this PR well received on login1

PR test command 'EB_PR=16152 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16152 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9090

Test results coming soon (I hope)...

- notification for comment with ID 1232487432 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/6471d5b08b96107fd5f591f9c4effb34 for a full test report.

@akesandgren
Copy link
Contributor Author

@boegelbot Please test @ generoso

@boegelbot
Copy link
Collaborator

@akesandgren: Request for testing this PR well received on login1

PR test command 'EB_PR=16152 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16152 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9097

Test results coming soon (I hope)...

- notification for comment with ID 1234018547 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akesandgren akesandgren changed the title fix top level Makefile for AmberTools 21 for intel update AmberTools 21 for intel with EasyBuild set of patches for AT 21.12 Sep 1, 2022
@branfosj
Copy link
Member

branfosj commented Sep 1, 2022

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u36b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/9131a481e44141782c7e8362296fc75e for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/92e17e2543a378eaa4e4edabf4965ec0 for a full test report.

@branfosj
Copy link
Member

branfosj commented Sep 2, 2022

Going in, thanks @akesandgren!

@branfosj branfosj merged commit 1eeff86 into easybuilders:develop Sep 2, 2022
@boegel boegel changed the title update AmberTools 21 for intel with EasyBuild set of patches for AT 21.12 add missing patches for AmberTools 21 with intel toolchain + enable running tests Sep 10, 2022
@boegel boegel changed the title add missing patches for AmberTools 21 with intel toolchain + enable running tests add missing patches for AmberTools 21 with intel/2021b toolchain + enable running tests Sep 10, 2022
@akesandgren akesandgren deleted the 20220829131650_new_pr_AmberTools21 branch September 12, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants