switch to Rust 1.60.0 build dependency for bamtofastq, since build of fails with Rust 1.52.1

[pberthier]

(created using eb --new-pr)

[pberthier]

Test report by @pberthier
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
softdev.binf.unibe.ch - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz, Python 3.6.8
See https://gist.github.com/db975c82458378acd0b5389e17a68d46 for a full test report.

[boegel]

@pberthier Do you have some more details here, the exact error that you're running into with Rust 1.52.1?

Because it definitely used to work, see #14391

[pberthier]

Does the build logfile helps?
easybuild-bamtofastq-1.4.0-20220609.121200.kBTnh.log

[boegel]

First error produced by Rust compiler:

error[E0658]: arbitrary expressions in key-value attributes are unstable
   --> /home/softdev/.cargo/registry/src/github.com-1ecc6299db9ec823/libz-sys-1.1.8/src/lib.rs:115:19
    |
115 |     #[link_name = zng_prefix!(adler32)]
    |                   ^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #78835 <https://github.com/rust-lang/rust/issues/78835> for more information
    = help: add `#![feature(extended_key_value_attributes)]` to the crate attributes to enable

That looks very similar to the problem that led me to use a more recent Rust version for tokenizers in #15587...

This is probably a result of pulling in Rust packages during the installation of Rust, it looks like we may be pulling in package versions that are not actually compatible with Rust 1.52.1 (while we weren't before).

@zao Any thoughts on this, since you're a bit more familiar with the Rust ecosystem?

[boegel]

Actually, it's probably because whatever Rust packages are required for bamtofastq are being downloaded on the fly during the installation of bamtofastq itself, without proper version locking...

So we're now pulling in libz-sys-1.1.8, which requires a Rust version newer than 1.52.1, while before we were pulling down an older version of libz-sys that worked fine with Rust 1.52.1.

So bumping the Rust version we're using as a build dep to something more recent is a short term solution, but we're bound to run into the same problem again later, and we need to properly fix this by making sure we install the same dependency versions...

[boegel]

@zao Any thoughts on this (since you're more familiar with the Rust ecosystem)?

[verdurin]

Ping @zao @boegel

[boegel]

@boegelbot please test @ generoso

[boegelbot]

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15636 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15636 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

• exit code: 0
• output:

Submitted batch job 8760

Test results coming soon (I hope)...

- notification for comment with ID 1163484033 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

[boegelbot]

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/bfb6fc58e86d146906627711f4dc4191 for a full test report.

[boegel]

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3138.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/6c2a90646eb12ee8b27e6e8491d960bc for a full test report.

[boegel]

lgtm

[boegel]

Going in, thanks @pberthier!

[boegel]

I've opened a separate issue on the broader problem here for follow-up, so we can get this PR merged as a temporary workaround for this specific problem; see #15763