-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
also build BLIS backend for FlexiBLAS v3.0.4 with GCC/10.3.0 #15347
also build BLIS backend for FlexiBLAS v3.0.4 with GCC/10.3.0 #15347
Conversation
@boegelbot: please test @ generoso |
@smoors: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1109867512 processed Message to humans: this is just bookkeeping information for me, |
Hold on, how can we have missed this in earlier testing?! cc @bartoldeman |
Test report by @boegelbot |
it's also weird that in generoso the test did not fail without this PR. |
@smoors It makes no sense to me that
if it wasn't built with a BLIS backend at all... How would it even know about BLIS in that case?! Are you sure that the problem with Note: @bartoldeman Do you have any ideas here? I'll rebuild |
@boegel mystery solved :)
it could still be useful to add support for BLIS here, but I understand that you don't want to introduce unnecessary changes to a toolchain module. |
@smoors Now that the mystery is solved, this is just an enhancement, which indeed makes sense, so let's get it applied... |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1111094335 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegel |
Test report by @boegelbot |
Test report by @boegel |
@boegelbot please test @ jsc-zen2 |
@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1111193805 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @smoors! |
(created using
eb --new-pr
)this is needed to avoid failing test reports withsee also #15334