Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix download URL in UDUNITS v2.2.28 easyconfigs #14954

Merged

Conversation

crubb
Copy link
Contributor

@crubb crubb commented Feb 5, 2022

(created using eb --new-pr)
Fix download URL, which now contains the version. The older versions are not on the server (anymore?)

@crubb crubb changed the title Fix download URL {phys}[GCCcore/10.3.0,GCCcore/11.2.0] UDUNITS v2.2.28 - Fix download URL Feb 5, 2022
@migueldiascosta migueldiascosta added this to the 4.x milestone Feb 7, 2022
@migueldiascosta
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@migueldiascosta: Request for testing this PR well received on login1

PR test command 'EB_PR=14954 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14954 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8078

Test results coming soon (I hope)...

- notification for comment with ID 1031138530 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns4 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/fe46cfdf126bab4a7ead795a21480907 for a full test report.

@migueldiascosta
Copy link
Member

@boegelbot please test @ jsc-zen2
EB_ARGS="--force-download"

@boegelbot
Copy link
Collaborator

@migueldiascosta: Request for testing this PR well received on jsfl1.int.jusuf.sebastian.cluster

PR test command 'EB_PR=14954 EB_ARGS="--force-download" /opt/software/slurm/bin/sbatch --job-name test_PR_14954 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1776

Test results coming soon (I hope)...

- notification for comment with ID 1031221929 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@migueldiascosta
Copy link
Member

Test report by @migueldiascosta
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
c2dhpc - Linux CentOS Linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/28d34fe82185fbb24f17dedeb3248bc7 for a full test report.

Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

@crubb so, their policy is that only the last patch version of each minor version is available? (https://artifacts.unidata.ucar.edu/service/rest/repository/browse/downloads-udunits/)

if that's the case, this patch version can also disappear in the future, so (@boegel) might as well add it now to https://sources.easybuild.io/u/UDUNITS/?

@migueldiascosta migueldiascosta changed the title {phys}[GCCcore/10.3.0,GCCcore/11.2.0] UDUNITS v2.2.28 - Fix download URL fix download URL in UDUNITS v2.2.28 easyconfigs Feb 8, 2022
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Feb 10, 2022

@crubb so, their policy is that only the last patch version of each minor version is available? (https://artifacts.unidata.ucar.edu/service/rest/repository/browse/downloads-udunits/)

if that's the case, this patch version can also disappear in the future, so (@boegel) might as well add it now to https://sources.easybuild.io/u/UDUNITS/?

Done!

@boegel
Copy link
Member

boegel commented Feb 10, 2022

Going in, thanks @crubb!

@boegel boegel merged commit 9638cca into easybuilders:develop Feb 10, 2022
@crubb crubb deleted the 20220205161728_new_pr_UDUNITS2228 branch February 10, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants