Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the version, fix spelling of a name, and add an extra sanity check command in pangolin #13848

Merged

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Aug 28, 2021

(created using eb --new-pr)

@branfosj branfosj requested a review from boegel August 28, 2021 09:41
@branfosj branfosj changed the title {bio}[foss/2020b] pangolin v3.1.11 w/ Python 3.8.6 correct the version, fix spelling of a name, and add an extra sanity check command in pangolin Aug 28, 2021
@branfosj branfosj added this to the next release (4.4.2?) milestone Aug 28, 2021
@branfosj
Copy link
Member Author

@boegelbot please test @ generoso

@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/70008acac15a50dfc846501410fd69f7 for a full test report.

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on generoso

PR test command 'EB_PR=13848 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13848 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 18234

Test results coming soon (I hope)...

- notification for comment with ID 907601780 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-7 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/aa26915f642a7324530eea1fbded883c for a full test report.

@sassy-crick
Copy link
Collaborator

sassy-crick commented Aug 28, 2021

Apologies for the wrong spelling of the name and the different versions. Well spotted @branfosj !
@boegel Please remove the wrong PR 13733 in favour of this one.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Aug 28, 2021

Test report by @Micket
SUCCESS
Build succeeded for 4 out of 4 (1 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/6dcfe759d792d320d201fa517c610e8c for a full test report.

@Micket
Copy link
Contributor

Micket commented Aug 28, 2021

Going in, thanks @branfosj!

@Micket Micket merged commit 23ddc6b into easybuilders:develop Aug 28, 2021
@branfosj branfosj deleted the 20210828103922_new_pr_pangolin3111 branch August 28, 2021 13:34
@boegel boegel added bug fix and removed update labels Aug 30, 2021
@boegel
Copy link
Member

boegel commented Aug 30, 2021

Totally overlooked this, thanks for the fix @branfosj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants