Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch back to Bundle easyblock for PyQt5 5.15.1 + add back source URLs for components #13371

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Jul 7, 2021

(created using eb --new-pr)

Fix for incomplete revert of #13253 done in #13336 which didn't revert the Bundle->PythonBundle change and missed the need to specify source_urls (as it is a bundle with components not pythonbundle with extensions)

@Micket Micket added the bug fix label Jul 7, 2021
@Micket Micket added this to the next release (4.4.2?) milestone Jul 7, 2021
@Micket
Copy link
Contributor

Micket commented Jul 7, 2021

Test report by @Micket
FAILED
Build succeeded for 20 out of 22 (2 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/2f23c9fa076b73397545d0ca4f5328c7 for a full test report.

Disk space issues, retrying

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
FAILED
Build succeeded for 17 out of 18 (2 easyconfigs in total)
taurusi6496.taurus.hrsk.tu-dresden.de - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/9cf44983fbc70cf7379e441c042110bf for a full test report.

@Micket
Copy link
Contributor

Micket commented Jul 7, 2021

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/6c052aae8296ff324445989edeb60fee for a full test report.

@Micket
Copy link
Contributor

Micket commented Jul 7, 2021

Any idea on your build failure @Flamefire ?

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Jul 8, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=13371 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13371 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17742

Test results coming soon (I hope)...

- notification for comment with ID 876013782 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/c66424fa3839dc56aadb13620c52c64c for a full test report.

@Flamefire
Copy link
Contributor Author

@Micket Not really, but doesn't look good. Retrying interactively...

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
taurusi8006 - Linux centos linux 7.9.2009, x86_64, AMD EPYC 7352 24-Core Processor (zen2), Python 2.7.5
See https://gist.github.com/2b28505fbee4b36c70fde61807ad199b for a full test report.

@Flamefire
Copy link
Contributor Author

Ok it works. Might have been interference from my other tests

@Flamefire
Copy link
Contributor Author

Flamefire commented Jul 8, 2021

Test report by @Flamefire
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
taurusa4 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz (broadwell), Python 2.7.5
See https://gist.github.com/8a07ae640ed1ed60182655216e052e78 for a full test report.

Edit: Ignore this. Missing patch for Qt5: https://www.mail-archive.com/easybuild@lists.ugent.be/msg06069.html

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
taurusa4 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz (broadwell), Python 2.7.5
See https://gist.github.com/b02011c860c8103e5f6ada3137cc1d87 for a full test report.

@Micket
Copy link
Contributor

Micket commented Jul 10, 2021

Going in, thanks @Flamefire!

@Micket Micket merged commit 0af5580 into easybuilders:develop Jul 10, 2021
@Flamefire Flamefire deleted the 20210707163443_new_pr_PyQt55151 branch July 12, 2021 08:34
@boegel boegel changed the title Fix PyQt 5.15.1 ECs switch back to Bundle easyblock for PyQt5 5.15.1 + add back source URLs for components Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants