Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch for GCCcore 10.3.0 to prevent issues when compiling with nvcc #13310

Merged

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jul 1, 2021

(created using eb --new-pr)

Details are in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100102

The tl;dr is nvcc triggers the gcc bug that this patch fixes.

@branfosj branfosj added this to the next release (4.4.1) milestone Jul 1, 2021
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title GCC fix to prevent issues when compiling with nvcc add patch for GCCcore 10.3.0 to prevent issues when compiling with nvcc Jul 1, 2021
@branfosj
Copy link
Member Author

branfosj commented Jul 1, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/64e0b551edf1ca109e3e88eba2068830 for a full test report.

@branfosj
Copy link
Member Author

branfosj commented Jul 1, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.8.5
See https://gist.github.com/172b33e5e61451d3941af9ebd14cd2fe for a full test report.

@boegel
Copy link
Member

boegel commented Jul 1, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3302.joltik.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), Python 3.6.8
See https://gist.github.com/989d0601166562591e3c40fb478b6093 for a full test report.

@branfosj
Copy link
Member Author

branfosj commented Jul 1, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0305u19a.bear.cluster - Linux RHEL 8.4, POWER, 8335-GTX (power9le), Python 3.6.8
See https://gist.github.com/8b9b944c07c4fdae200154fc39b7157b for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
centos8-eb - Linux centos linux 8.3.2011, x86_64, Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (skylake), Python 3.6.8
See https://gist.github.com/5434e09810f3253e1f6e88ab93be3bdf for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
rocky8-eb - Linux rocky linux 8.4, x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.6.8
See https://gist.github.com/ce95ad6764ca168daf110cc668905910 for a full test report.

@Micket
Copy link
Contributor

Micket commented Jul 1, 2021

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/90596fd1984e957465b70d405474cb99 for a full test report.

@Micket
Copy link
Contributor

Micket commented Jul 1, 2021

Going in, thanks @branfosj!

@Micket Micket merged commit 0dc7b06 into easybuilders:develop Jul 1, 2021
@branfosj branfosj deleted the 20210701193025_new_pr_GCCcore1030 branch July 2, 2021 06:03
@boegel
Copy link
Member

boegel commented Jul 2, 2021

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=13310 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13310 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17694

Test results coming soon (I hope)...

- notification for comment with ID 872810545 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/972c49e01853276ef4dace8648a59dfe for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants