Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{geo}[SYSTEM] SNAP-ESA v8.0 and python interface with Python-2.7.18/GCCcore-10.2.0 #13198

Merged
merged 11 commits into from
Oct 18, 2023

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Jun 17, 2021

Depends on #13141

This PR has the particularity that the Python module for SNAP-ESA snappy is installed using a tool from SNAP-ESA instead of using some sources. Therefore, I made a creative use of Bundle for SNAP-ESA-python.

On top of that, several commands of SNAP fail to properly terminate themselves after the execution is complete. They just hang forever. This issue is known by the devs but there is no fix (probably low priority because ctrl-C is easy enough 😆 ). So I resorted to parse the output of those tools and manually kill them once they are done.

The update of SNAP's modules is disabled by default because there is no way to control which versions get installed with it. It always downloads the latests versions from their repos. Use at your own risk.

@lexming lexming added the new label Jun 17, 2021
@boegelbot

This comment has been minimized.

@lexming
Copy link
Contributor Author

lexming commented Jul 4, 2021

Test report by @lexming
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node381.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/5b0ace71e6d5c75bb4496b2608e99de5 for a full test report.

Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As decided in issue #16330, we have deprecated the use of True to signify a system-toolchain dependency (#16384), in favour of the more intuitive SYSTEM template constant. Due to the change in the test suite, please run eb --sync-pr-with-develop 13198 and update the PR to use SYSTEM instead.

@boegel boegel added this to the 4.x milestone Oct 13, 2023
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see lexming#2

use Java/1.8 wrapper for SNAP-ESA and SNAP-ESA-python + take into account that `$JAVA_TOOL_OPTIONS` may not be defined + add modtclfooter equivalent to modluafooter
@lexming
Copy link
Contributor Author

lexming commented Oct 18, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=13198 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_13198 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11955

Test results coming soon (I hope)...

- notification for comment with ID 1768022319 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f211cb1a6ef01994090b11c126b84801 for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Oct 18, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=13198 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_13198 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3573

Test results coming soon (I hope)...

- notification for comment with ID 1768135056 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/59808e637eb714606473dcebf414ab94 for a full test report.

@boegel
Copy link
Member

boegel commented Oct 18, 2023

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3130.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/6e3124a6fed0d259a5c3bf1a7ce2d41f for a full test report.

@boegel
Copy link
Member

boegel commented Oct 18, 2023

Going in, thanks @lexming!

@boegel
Copy link
Member

boegel commented Oct 18, 2023

Going in, thanks @lexming!

@boegel boegel merged commit 6da1d50 into easybuilders:develop Oct 18, 2023
5 checks passed
@boegel boegel modified the milestones: 4.x, next release (4.8.2?) Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants