-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch UCX to add CUDA support at runtime #12866
Patch UCX to add CUDA support at runtime #12866
Conversation
So, I think this works. ucx_info manages to find and report on CUDA stuff. But, there are some details to sort out when it comes to building the additional UCX-plugins; I would like them link to the existing libuct.so etc. libraries. Right now, I hackishly install the plugins. Alternatively, we can just install copies of those libraries, they should hopefully be identical anyway. |
@Micket Do you think it's worth implementing a custom easyblock for this, where we can check the output produced by This easyconfig looks complex enough to warrant that, I think... |
Sure, though it's mostly just the same as UCX. We could probably automatically populate EB_xxx_MODULES here. The biggest issue is
|
UCS_INIT_ONCE(init_once) { | ||
ucs_module_debug("loading modules for %s", framework); | ||
- modules_str = ucs_strdup(modules, "modules_list"); | ||
+ sprintf(env, "EB_%s_MODULES", framework); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use strncpy, strncat, strncat here instead, then you can drop stdio and stdlib and do string.h instead.
This one no longer need the original UCX nor the patch for dynamic modules. |
@Micket: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/885348992
bleep, bloop, I'm just a bot (boegelbot v20200716.01) |
Replaced with #13260 |
(created using
eb --new-pr
)