-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{devel}[GCC/9.3.0,iccifort/2020.1.217] Boost.Serial v1.72.0 #11145
{devel}[GCC/9.3.0,iccifort/2020.1.217] Boost.Serial v1.72.0 #11145
Conversation
As discussed with Kenneth, deleting this version, replacing with Boost.Serial.
@SimonPinches, this is a change for Boost"-no_mpi" introduced previously. After the EB call today, we are introducing Boost.Serial, instead of having a version suffix. |
Test report by @zao |
Sanity check seems hosed as per my test report, on my system files are decorated like:
|
Mmm, that seems to be an EasyBlock problem ? I have no custom sanity_check paths in the EC. |
Changed target to easybuilders:dual_serial_mpi |
Test report by @lexming |
Test report by @lexming |
@mboisson thanks for the heads-up regarding the change of suffix name. I have to say I'm sorry to see the loss of a |
@SimonPinches going down to |
@lexming, the reason even Compute Canada did not do that is that we will always want to have a Boost with GCC and one with Intel. Bringing it down to GCCcore means that users run the risk of using GCC-compiled libraries with Intel, or that we need to forgo optimizations brought forward by the Intel compiler (which can be useful for algorithms in Boost). |
Fixes for the failed tests can be found in |
Test report by @lexming |
Test report by @lexming |
Test report by @migueldiascosta |
Test report by @lexming |
Test report by @lexming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going in, thanks @mboisson ! |
(created using
eb --new-pr
)