Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTF2 & Score-P] Move builddependencies to dependencies #10496

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

Flamefire
Copy link
Contributor

As discussed in #10397 (comment) those should be runtime dependencies as they are used at runtime

CCing @lexming as he merged #10397

As discussed in easybuilders#10397 (comment)
those should be runtime dependencies as they are used at runtime
@lexming
Copy link
Contributor

lexming commented Apr 27, 2020

@Flamefire You are late to the party #10482 😉
I'll close my PR though, as yours is more complete than mine.

@lexming
Copy link
Contributor

lexming commented Apr 27, 2020

Test report by @lexming
SUCCESS
Build succeeded for 8 out of 8 (3 easyconfigs in this PR)
node154.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/2b1860d8951c7e670a8ebf3fe24e7c34 for a full test report.

Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Apr 27, 2020

Going in, thanks @Flamefire !

@lexming lexming merged commit 1c3ab48 into easybuilders:develop Apr 27, 2020
@Flamefire Flamefire deleted the otf2 branch April 27, 2020 13:42
boegel added a commit to boegel/easybuild-easyconfigs that referenced this pull request Jul 3, 2020
boegel added a commit to boegel/easybuild-easyconfigs that referenced this pull request Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants