Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Mako easyconfigs using a */2018* toolchain #10480

Merged
merged 2 commits into from
Apr 25, 2020
Merged

fix Mako easyconfigs using a */2018* toolchain #10480

merged 2 commits into from
Apr 25, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented Apr 24, 2020

partial fix for #10462

@boegel boegel added the bug fix label Apr 24, 2020
@boegel boegel added this to the next release (4.2.1?) milestone Apr 24, 2020
@boegel
Copy link
Member Author

boegel commented Apr 24, 2020

Test report by @boegel
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in this PR)
node2697.swalot.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/4c4bad05e99f30a9de00c0ef1cb50d19 for a full test report.

@boegel
Copy link
Member Author

boegel commented Apr 24, 2020

Test report by @boegel
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in this PR)
node3402.kirlia.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/93b18d9e09cd1dc74d7730df6b9591ad for a full test report.

@lexming
Copy link
Contributor

lexming commented Apr 24, 2020

Test report by @lexming
FAILED
Build succeeded for 6 out of 10 (10 easyconfigs in this PR)
node150.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/b672340c54f8e19d5c7b6559db56387b for a full test report.

@lexming
Copy link
Contributor

lexming commented Apr 25, 2020

Several of our old Python installations are not up to date with changes in Easybuild, so I'll have to rebuild those before I can test this PR.

@lexming
Copy link
Contributor

lexming commented Apr 25, 2020

Test report by @lexming
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in this PR)
node150.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/4845174e5d402f59276d8d79c5838e9c for a full test report.

lexming
lexming approved these changes Apr 25, 2020
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Apr 25, 2020

Going in, thanks @boegel !

@lexming lexming merged commit 9ed70b2 into easybuilders:develop Apr 25, 2020
@boegel boegel deleted the fix_Mako_2018 branch April 26, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexming lexming lexming approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @lexming