Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{bio}[foss/2018b] artic-ncov2019 v2020.04.13, rampart v1.2.0rc3, gotree v0.4.0, ... w/ Python 3.6.6 #10459

Merged
merged 9 commits into from
Apr 29, 2020
Merged

{bio}[foss/2018b] artic-ncov2019 v2020.04.13, rampart v1.2.0rc3, gotree v0.4.0, ... w/ Python 3.6.6 #10459

merged 9 commits into from
Apr 29, 2020

Conversation

Darkless012
Copy link
Contributor

@Darkless012 Darkless012 commented Apr 23, 2020 •
edited by boegel
Loading

(created using eb --new-pr)
requires: #10458 (Clang) for Longshot, #7735 (ETE), #10469 (goalign, gotree), #10464 (minimap2) for libdeflate

@Darkless012
adding easyconfigs: artic-ncov2019-2020.04.13-foss-2018b-Python-3.6.6…
247f9db 
…-medaka.eb, rampart-1.2.0rc3-foss-2018b-Python-3.6.6.eb, gotree-0.4.0-binary.eb, goalign-0.3.2-binary.eb, IQ-TREE-1.6.12-foss-2018b.eb, Longshot-0.4.1-foss-2018b.eb, MAFFT-7.427-foss-2018b-with-extensions.eb, MUSCLE-3.8.1551-foss-2018b.eb, nodejs-12.16.1-GCCcore-7.3.0.eb, Rust-1.42.0-GCCcore-7.3.0.eb
boegel
boegel requested changes Apr 23, 2020
View reviewed changes
easybuild/easyconfigs/i/IQ-TREE/IQ-TREE-1.6.12-foss-2018b.eb Outdated Show resolved Hide resolved
easybuild/easyconfigs/l/Longshot/Longshot-0.4.1-foss-2018b.eb Outdated Show resolved Hide resolved
easybuild/easyconfigs/m/MUSCLE/MUSCLE-3.8.1551-foss-2018b.eb Outdated Show resolved Hide resolved
...ild/easyconfigs/a/artic-ncov2019/artic-ncov2019-2020.04.13-foss-2018b-Python-3.6.6-medaka.eb Outdated Show resolved Hide resolved
easybuild/easyconfigs/g/goalign/goalign-0.3.2-binary.eb Outdated Show resolved Hide resolved
easybuild/easyconfigs/r/rampart/rampart-1.2.0rc3-foss-2018b-Python-3.6.6.eb Show resolved Hide resolved
easybuild/easyconfigs/r/rampart/rampart-1.2.0rc3-foss-2018b-Python-3.6.6.eb Show resolved Hide resolved
easybuild/easyconfigs/r/rampart/rampart-1.2.0rc3-foss-2018b-Python-3.6.6.eb Outdated Show resolved Hide resolved
easybuild/easyconfigs/r/rampart/rampart-1.2.0rc3-foss-2018b-Python-3.6.6.eb
# Don't ever try to install unpacked source of nodejs globally!
# Always use 'npm install -g downloaded_file.tar.gz` or you will end up having broken links and installation will fail.
# -d (debug) and --timing can show errors while downloading dependencies
local_install_cmd = "npm install -d --timing --prefix %(installdir)s -g v%(version)s.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many dependencies are involved here? Can we avoid that they're auto-downloaded by installing them ourselves?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot, and I don't want to touch nodejs and its dependencies anymore.

easybuild/easyconfigs/r/rampart/rampart-1.2.0rc3-foss-2018b-Python-3.6.6.eb Outdated Show resolved Hide resolved
@easybuilders easybuilders deleted a comment from boegelbot Apr 24, 2020
@boegel boegel added this to the 4.x milestone Apr 24, 2020
@easybuilders easybuilders deleted a comment from boegelbot Apr 27, 2020
@boegel
Copy link
Member

boegel commented Apr 29, 2020

Test report by @boegel
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, x86_64, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/c91731f172954dfbec0f9ec5043eade1 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Apr 29, 2020
@boegel
Copy link
Member

boegel commented Apr 29, 2020

Test report by @boegel
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in this PR)
node3102.skitty.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/4f1b5fbebb7b9b4eda1368d577b8f407 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.2.1?) Apr 29, 2020
@boegel
Copy link
Member

boegel commented Apr 29, 2020

Going in, thanks @Darkless012!

@boegel boegel merged commit 141b445 into easybuilders:develop Apr 29, 2020
@boegel
Copy link
Member

boegel commented Apr 29, 2020

Test report by @boegel
SUCCESS
Build succeeded for 15 out of 15 (10 easyconfigs in this PR)
node2500.golett.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/a653e5a4c6f8bf3b47bfd8b102be0824 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
new update
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Darkless012 @boegel