Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance ConfigureMake generic easyblock to allow using it to install extensions #979

Closed
wants to merge 2 commits into from

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 19, 2016

No description provided.

@boegel boegel added this to the v2.9.0 milestone Aug 19, 2016
@boegel
Copy link
Member Author

boegel commented Aug 19, 2016

@wpoely86, @hajgato: please review

@ocaisa: this is a small enhancement to the ConfigureMake easyblock in order to support installing a bundle of X11 packages... (PR with easyconfig coming up)

@hajgato
Copy link
Collaborator

hajgato commented Aug 22, 2016

@boegel Its seems fine for me. I do not see what would be the consequences for other easyblocks, like in the case of PERL module. Is this the only one that affected?

@wpoely86
Copy link
Member

👍

@boegel
Copy link
Member Author

boegel commented Aug 22, 2016

@hajgato the PerlModule generic easyblock should be the only one affected, yes; the change is needed because by making ConfigureMake derive from ExtensionEasyblock, we block multiple inheritance there...

I've been thinking some more about this, and I've been wondering whether this is the right approach. The extensions mechanism is really intended for stuff like Pyhton packages, Perl modules, R libraries, etc., i.e. language-specific packages that require a particular software package as a dependency.

By enhancing ConfigureMake like we do here, we've somewhat abusing this mechanism for other purposes.

I think maybe we should be enhancing the Bundle easyblock to support specifying a list of components instead, where you can indicate using which easyblock each of these components should be installed? That's a proper and more generic approach, but I'm not sure how easy/hard it would be to implement that... Thoughts?

@hajgato
Copy link
Collaborator

hajgato commented Aug 22, 2016

@boegel I do think that Bunde should be enhanced as you said. The final goal should be the ability to install more than one package to a common "prefix". (But I do not see so deep into framework/blocks)

@boegel
Copy link
Member Author

boegel commented Aug 22, 2016

superseded by #980

@boegel boegel closed this Aug 22, 2016
@boegel boegel deleted the configuremake_extensions branch August 22, 2016 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants