Update AOCC easyblock to work with LLVM 16 and above #3437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thyre
suggested changes
Sep 6, 2024
Comment on lines
+70
to
+73
| # Starting from LLVM v16, the folder naming is based on the major version of clang. | ||
| if LooseVersion(self.clangversion) >= LooseVersion('16.0.0'): | ||
| self.clangversion = '16' | ||
|
|
There was a problem hiding this comment.
This will break once AOCC updates to a newer Clang version. In addition, updating the clangversion to the major version only feels not correct. This is only needed for the sanity check. Therefore, such conversion should only be done where necessary.
In the Clang EasyBlock, the conversion is done during the sanity check. We should be able to mostly copy the code. I've posted a draft for AOCC in the issue for this EasyBlock (#3429 (comment)), but didn't have the time to create a PR and test it.
| # Starting from LLVM v16, the folder naming is based on the major version of clang. | ||
| if LooseVersion(self.clangversion) >= LooseVersion('16.0.0'): | ||
| self.clangversion = '16' | ||
|
|
||
| def _aocc_guess_clang_version(self): |
There was a problem hiding this comment.
We should update the list with known AOCC versions, since this simplifies writing the respective EasyConfigs
|
Is this superseded by #3458? |
|
Closing in favor of #3458 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #3429