Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning if .Renviron detected during install of RPackage #3263

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Mar 30, 2024

(created using eb --new-pr)

fixes #867

@branfosj branfosj added this to the 5.0 milestone Mar 30, 2024
@branfosj branfosj changed the title add warning if .Renviron detected during install of RPackage add warning if .Renviron detected during install of RPackage Mar 30, 2024
@boegel
Copy link
Member

boegel commented Apr 6, 2024

@boegelbot please test @ jsc-zen3
EB_BRANCH=5.0.x
EB_ARGS="Seurat-5.0.1-foss-2022b-R-4.2.2.eb sceasy-0.0.7-foss-2022a-R-4.2.1.eb rjags-4-13-foss-2022b-R-4.2.2.eb"

@boegelbot
Copy link

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=3263 EB_ARGS="Seurat-5.0.1-foss-2022b-R-4.2.2.eb sceasy-0.0.7-foss-2022a-R-4.2.1.eb rjags-4-13-foss-2022b-R-4.2.2.eb" EB_REPO=easybuild-easyblocks EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_3263 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3923

Test results coming soon (I hope)...

- notification for comment with ID 2041058969 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS Seurat-5.0.1-foss-2022b-R-4.2.2.eb
  • SUCCESS sceasy-0.0.7-foss-2022a-R-4.2.1.eb
  • SUCCESS JAGS-4.3.2-foss-2022b.eb
  • SUCCESS rjags-4-13-foss-2022b-R-4.2.2.eb

Build succeeded for 4 out of 4 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/262803a19cef51bbdd0ce867ccdae6b5 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit f2423db into easybuilders:5.0.x Apr 6, 2024
17 checks passed
@branfosj branfosj deleted the 20240330114755_new_pr_rpackage branch April 6, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants