-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure localrc is created in the correct subdir for NVHPC v22.9+ #3240
ensure localrc is created in the correct subdir for NVHPC v22.9+ #3240
Conversation
Test report by @jfgrimm Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (5 easyconfigs in total) edit: I can confirm that all the above modules can now compile the example without issues |
@jfgrimm Can we add that minimal test as a sanity check command in |
@boegel we could, but it will only show up when the system compiler is older than GCC 9, no? |
That doesn't seem unlikely to me:
It's just good to catch this type of problem early on via a lightweight sanity check, we shouldn't declare success on the installation if it's picking up the wrong GCC... |
Test report by @jfgrimm Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (5 easyconfigs in total) |
@boegel done |
@boegelbot please test @ generoso |
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1973357008 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
My failure is with EB5
but then we unload the module
so
|
@branfosj We should pass the I'll take a quick look at that... |
ah right |
run minimal NVHPC compilation command via custom_commands passed to sanity_check_step
@boegelbot please test @ jsc-zen3 |
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1973401312 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 2 (2 easyconfigs in total) |
@boegel are we using an unsupported GCC/CUDA combination in NVHPC 24.1? I'm not sure there is a CUDA release that supports GCC 13.x yet... edit: hmm, compiling the example with NVHPC 24.1 doesn't fail for me |
@boegelbot please test @ generoso |
I suspect it may be a problem with RHEL 9.x more than with the GCC being used... That issue shouldn't block this PR. |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1974785517 processed Message to humans: this is just bookkeeping information for me, |
@boegelbot please test @ generoso |
@SebastianAchilles: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1981851883 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 12 out of 15 (15 easyconfigs in total) |
Co-authored-by: Mikael Öhman <micketeer@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@boegelbot please test @ generoso |
@Micket: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2032452776 processed Message to humans: this is just bookkeeping information for me, |
Test report by @Micket Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
@boegelbot please test @ jsc-zen3 |
@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2032514951 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 7 out of 8 (7 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Not sure what to make of the NVHPC-24.1-CUDA-12.3.0.eb failure on jsc-zen3. |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
@Micket That's most likely due to GCC 13.2 and CUDA 12.3.0 not being compatible, see also #20158, so that shouldn't block this PR. |
To fix issue reported in slack. Currently, compiling the following minimal example fails:
Ss noticed by @branfosj:
During the install we use
makelocalrc
to generate alocalrc
file. This has a bunch of pointers to the GCC install.In my working 22.3 install, there is one of these files. In
Linux_x86_64/22.3/compilers/bin/localrc
In my broken 24.1 install there are two of them
The second of these is the one generated by EB and is correct. The first one has a mix of OS GCC and EB GCC in it.
(created using
eb --new-pr
)