Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the blas/lapack name passed to meson when building recent scipy versions (>= 1.9.0) on top of Intel MKL #3024

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

schiotz
Copy link
Contributor

@schiotz schiotz commented Oct 24, 2023

The meson script expects the pkg-config name of the MKL package, instead of just 'mkl'. See easybuilders/easybuild-easyconfigs#18875

@schiotz
Copy link
Contributor Author

schiotz commented Oct 24, 2023

Note that this should not break any existing easyconfigs (*), as there is no intel-based SciPy-bundle new enough to build using meson.

(*) Famous last words...

@schiotz schiotz marked this pull request as draft October 24, 2023 10:43
@schiotz schiotz marked this pull request as ready for review October 24, 2023 16:41
@boegel boegel added the bug fix label Oct 25, 2023
@boegel boegel added this to the next release (4.8.2?) milestone Oct 25, 2023
@boegel boegel changed the title Fix the blas/lapack name passed to meson when building scipy with MKL. Fix the blas/lapack name passed to meson when building recent scipy versions (>= 1.9.0) on top of Intel MKL Oct 25, 2023
@boegel
Copy link
Member

boegel commented Oct 25, 2023

@boegelbot please test @ jsc-zen2
EB_ARGS="SciPy-bundle-2022.05-intel-2022a.eb"

@boegelbot
Copy link

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=3024 EB_ARGS="SciPy-bundle-2022.05-intel-2022a.eb" EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_3024 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3639

Test results coming soon (I hope)...

- notification for comment with ID 1778706390 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS SciPy-bundle-2022.05-intel-2022a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/95d3cf018b70cb3cfdc301afd74916f4 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 52f3b5f into easybuilders:develop Oct 25, 2023
46 checks passed
@boegel boegel changed the title Fix the blas/lapack name passed to meson when building recent scipy versions (>= 1.9.0) on top of Intel MKL fix the blas/lapack name passed to meson when building recent scipy versions (>= 1.9.0) on top of Intel MKL Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants